[dotnet] store the mutated element for the user not just the target id - #12948
Merged
Conversation
nvborisenko
reviewed
Oct 13, 2023
titusfortner
force-pushed
the
mutate_element
branch
from
October 14, 2023 19:22
c94fa6a to
d00c947
Compare
Member
Author
|
There are a few places where the Args template isn't storing the useful information but I do not want to spend time on any of this if we can start pushing the actual BiDi spec. Actually, it probably is forward compatible the way it is written. We can add the more useful things with the correct classes in the next implementation. Just frustrating right now. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an element is mutated it returns the ID of the element, this stores that element in the representative Data class instead of just the target ID.
Motivation and Context
Required now:
Desired:
Java:
Ruby: