[py] Update WPEWebKit support code - #13278
Merged
Merged
Conversation
diemol
reviewed
Dec 11, 2023
titusfortner
requested changes
Dec 11, 2023
titusfortner
left a comment
Member
There was a problem hiding this comment.
To be honest, I think these classes should be in a separate library from Selenium. You should be able to subclass what is there and have it work properly. (If you can't, we should fix that). If it's in Selenium, it should match what the other drivers are doing.
lauromoura
force-pushed
the
wpewebkit-update
branch
from
December 18, 2023 11:51
e090706 to
64353dc
Compare
lauromoura
requested review from
diemol,
sandeepsuryaprasad and
titusfortner
December 18, 2023 11:52
lauromoura
force-pushed
the
wpewebkit-update
branch
from
December 18, 2023 11:57
2165aa0 to
6420832
Compare
Contributor
Author
|
(Updated after missign a tox fix and rebase) |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13278 +/- ##
==========================================
+ Coverage 58.07% 58.18% +0.10%
==========================================
Files 88 88
Lines 5340 5330 -10
Branches 224 224
==========================================
Hits 3101 3101
+ Misses 2015 2005 -10
Partials 224 224 ☔ View full report in Codecov by Sentry. |
diemol
approved these changes
Dec 18, 2023
- Naming conventions, as WPEWebKit does not follow the Simple capitalized name scheme - (TODO): Driver location finding
- To match parent Service class Amend into Update WPEWebKit service parameter
Receiving a Service instance instead of service details spread out
lauromoura
force-pushed
the
wpewebkit-update
branch
from
January 15, 2024 04:53
1f6b7ce to
f1bd50e
Compare
Contributor
Author
|
Pinging @titusfortner for review |
lauromoura
added a commit
to lauromoura/WebKit
that referenced
this pull request
Mar 29, 2024
https://bugs.webkit.org/show_bug.cgi?id=267836 Reviewed by NOBODY (OOPS!). Bump selenium tests to upstream 907b2197dada02, which includes the fixes for WPE from SeleniumHQ/selenium#13278 The changes in our runner code were minimal, basically moving the driver name to lowercase. * Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py: (WebDriverWPE.selenium_name): * WebDriverTests/imported/selenium/common/: Updated to new revision * WebDriverTests/imported/selenium/importer.json: Update hash to be imported * WebDriverTests/imported/selenium/py: Updated to new revision
webkit-commit-queue
pushed a commit
to lauromoura/WebKit
that referenced
this pull request
Apr 1, 2024
https://bugs.webkit.org/show_bug.cgi?id=267836 Reviewed by Carlos Garcia Campos. Bump selenium tests to upstream 907b2197dada02, which includes the fixes for WPE from SeleniumHQ/selenium#13278 The changes in our runner code were minimal, basically moving the driver name to lowercase. * Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py: (WebDriverWPE.selenium_name): * WebDriverTests/imported/selenium/common/: Updated to new revision * WebDriverTests/imported/selenium/importer.json: Update hash to be imported * WebDriverTests/imported/selenium/py: Updated to new revision Canonical link: https://commits.webkit.org/276878@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the support code around WPEWebKit helper modules after the last update, a couple of years ago.
Motivation and Context
In the recent Selenium versions, some changes in the way the driver classes are named and the move towards options instead of raw capabilities dictionaries, alongside other minor issues, made the existing WPEWebkit module to fail to create the driver correctly. For example, failing either to find the right service executable or failing the capability verification.
The WPEWebKit is a WebKit port focused on embedded devices. Developers creating WebApps for these devices can take advantage of the remote webdriver (used by these helper classes) to automate testing directly on the device.
Types of changes
Checklist
wpewebkit.Serviceparameter, but they're not yet covered by the API docs. Should I add them in a separate PR?//py:test-wpewebkitpasses, with some specific failures that will be dealt in a separate PR.