Skip to content

[dotnet] Update Moq test dependency - #15085

Merged
nvborisenko merged 4 commits into
SeleniumHQ:trunkfrom
RenderMichael:nuget-warning
Feb 1, 2025
Merged

[dotnet] Update Moq test dependency#15085
nvborisenko merged 4 commits into
SeleniumHQ:trunkfrom
RenderMichael:nuget-warning

Conversation

@RenderMichael

@RenderMichael RenderMichael commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement, Tests


Description

  • Updated Moq dependency to version 4.20.72 across multiple files.

  • Adjusted dependency configurations in paket.nuget.bzl and paket.dependencies.

  • Updated project files to reflect the new Moq version.

  • Ensured compatibility with the new Moq version in test projects.


Changes walkthrough 📝

Relevant files
Enhancement
paket.nuget.bzl
Update `Moq` dependency in `paket.nuget.bzl`                         

dotnet/paket.nuget.bzl

  • Updated Moq dependency version from 4.12.0 to 4.20.72.
  • Adjusted dependency details such as sha512 and framework
    compatibility.
  • +1/-1     
    workspace.bzl
    Update `Moq` package reference in `workspace.bzl`               

    dotnet/workspace.bzl

  • Updated Moq package file reference to version 4.20.72.
  • Adjusted sha256 checksum for the new package.
  • +1/-1     
    paket.dependencies
    Update `Moq` version in `paket.dependencies`                         

    dotnet/paket.dependencies

    • Updated Moq dependency version from 4.12.0 to 4.20.72.
    +1/-1     
    Tests
    WebDriver.Common.Tests.csproj
    Update `Moq` version in `WebDriver.Common.Tests.csproj`   

    dotnet/test/common/WebDriver.Common.Tests.csproj

    • Updated Moq package reference version from 4.13.0 to 4.20.72.
    +1/-1     
    WebDriver.Support.Tests.csproj
    Update `Moq` version in `WebDriver.Support.Tests.csproj` 

    dotnet/test/support/WebDriver.Support.Tests.csproj

    • Updated Moq package reference version from 4.13.0 to 4.20.72.
    +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @qodo-code-review

    Copy link
    Copy Markdown
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-code-review

    Copy link
    Copy Markdown
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Comment thread dotnet/paket.nuget.bzl
    @nvborisenko

    Copy link
    Copy Markdown
    Member

    Blocked by #15063

    Comment thread dotnet/paket.dependencies
    @nvborisenko
    nvborisenko merged commit b48493b into SeleniumHQ:trunk Feb 1, 2025
    @RenderMichael
    RenderMichael deleted the nuget-warning branch February 1, 2025 14:30
    sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Mar 23, 2025
    Co-authored-by: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com>
    gryznar pushed a commit to gryznar/selenium that referenced this pull request May 17, 2025
    Co-authored-by: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants