Skip to content

Fix browserName typo for Edge WebView2 - #8455

Merged
AutomatedTester merged 3 commits into
SeleniumHQ:masterfrom
bwalderman:webview2
Jun 24, 2020
Merged

Fix browserName typo for Edge WebView2#8455
AutomatedTester merged 3 commits into
SeleniumHQ:masterfrom
bwalderman:webview2

Conversation

@bwalderman

Copy link
Copy Markdown
Contributor

Description

MsEdgeDriver lets clients request the browserName = "webview2" capability to drive native apps using the WebView2 control. Selenium users can set this using the EdgeOptions.UseWebView property.

Turns out there are a couple problems with this property's implementation:

  1. It was attempting to use "WebView2" as the browserName, but msedgedriver expects "webview2" (lowercase)
  2. An abstract property was added to the ChromiumDriver base class so that Edge and Chrome could supply whatever browserName values they wanted, but this property was being read only once on construction. Setting EdgeOptions.UseWebView = true wouldn't actually change the browserName.

Motivation and Context

Fixing a regression due to the introduction of the .UseWebView property.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bwalderman
bwalderman marked this pull request as ready for review June 24, 2020 16:22
@AutomatedTester
AutomatedTester merged commit 0d5b2de into SeleniumHQ:master Jun 24, 2020
titusfortner pushed a commit to titusfortner/selenium that referenced this pull request Aug 13, 2020
* Fix browserName typo for Edge WebView2

* Fix whitespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants