Fix browserName typo for Edge WebView2 - #8455
Merged
Merged
Conversation
bwalderman
marked this pull request as ready for review
June 24, 2020 16:22
AutomatedTester
approved these changes
Jun 24, 2020
titusfortner
pushed a commit
to titusfortner/selenium
that referenced
this pull request
Aug 13, 2020
* Fix browserName typo for Edge WebView2 * Fix whitespace.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MsEdgeDriver lets clients request the browserName = "webview2" capability to drive native apps using the WebView2 control. Selenium users can set this using the EdgeOptions.UseWebView property.
Turns out there are a couple problems with this property's implementation:
Motivation and Context
Fixing a regression due to the introduction of the .UseWebView property.
Types of changes
Checklist