[tracing] Instrumenting events for errors in existing trace spans in Grid - #8531
Merged
AutomatedTester merged 4 commits intoJul 16, 2020
Merged
Conversation
| span.setStatus(Status.UNKNOWN); | ||
| Map<String, EventAttributeValue> attributeValueMap = new HashMap<>(); | ||
| attributeValueMap.put("Error Message", EventAttribute.setValue(e.getMessage())); | ||
| span.addEvent("Unknown error in LocalDistributor while creating session",attributeValueMap); |
Member
There was a problem hiding this comment.
nit: make sure there are spaces after a ,
Suggested change
| span.addEvent("Unknown error in LocalDistributor while creating session",attributeValueMap); | |
| span.addEvent("Unknown error in LocalDistributor while creating session", attributeValueMap); |
Contributor
Author
There was a problem hiding this comment.
Thank you David. I formatted the changes as needed. Sorry missed this out.
pujagani
force-pushed
the
tracing_add_errorevents
branch
from
July 16, 2020 06:12
38ee653 to
8433841
Compare
AutomatedTester
approved these changes
Jul 16, 2020
titusfortner
pushed a commit
to titusfortner/selenium
that referenced
this pull request
Aug 13, 2020
…Grid (SeleniumHQ#8531) Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The changes made are related to the issue #6703. The code changes add events to existing spans of the trace for error conditions.
Motivation and Context
Traces include spans, which can have timed events. These events act as logs. Having events in spans in case of error with detailed error message and useful attributes will help in debugging.
Types of changes
Checklist