Skip to content

Add redis sessionmap doc - #8543

Merged
AutomatedTester merged 4 commits into
SeleniumHQ:trunkfrom
raju249:redis-session-map-info
Jul 20, 2020
Merged

Add redis sessionmap doc#8543
AutomatedTester merged 4 commits into
SeleniumHQ:trunkfrom
raju249:redis-session-map-info

Conversation

@raju249

@raju249 raju249 commented Jul 17, 2020

Copy link
Copy Markdown
Member

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

This PR adds an sessionmaps option to the info command. It talks about the RedisBackedSessionMap. What is it and how to use it.

Motivation and Context

This will help the user to check the documentation while on the command line. This is done in addition to already existing help commands like security, tracing etc.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@raju249 raju249 changed the title Add sessionmap doc Add redis sessionmap doc Jul 17, 2020
@raju249
raju249 force-pushed the redis-session-map-info branch from eb10bd0 to 3758dfb Compare July 17, 2020 10:20
`RedisBackedSessionMap` uses Redis as datastore for key, value store.
Below are the steps to start a `RedisBackedSessionMap`.

1. Set an environment variable using `export SESSION_IMPLEMENTATION='org.openqa.selenium.grid.sessionmap.redis.RedisBackedSessionMap'`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a typo, should be SESSIONS.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Good catch 👍

Fixed!

@raju249
raju249 force-pushed the redis-session-map-info branch from 735553a to cea1e44 Compare July 20, 2020 07:02
@AutomatedTester
AutomatedTester merged commit a28b4be into SeleniumHQ:trunk Jul 20, 2020
titusfortner pushed a commit to titusfortner/selenium that referenced this pull request Aug 13, 2020
Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants