Skip to content

[JS] Kill opera service on quit - #8581

Merged
diemol merged 2 commits into
SeleniumHQ:trunkfrom
harsha509:trunk
Jul 29, 2020
Merged

[JS] Kill opera service on quit#8581
diemol merged 2 commits into
SeleniumHQ:trunkfrom
harsha509:trunk

Conversation

@harsha509

@harsha509 harsha509 commented Jul 28, 2020

Copy link
Copy Markdown
Contributor

Description

WebDriver control flow is deprecated long ago, so removing opt_flow and replacing with service.kill()

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol diemol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @harsha509!

@diemol
diemol merged commit 5904d9c into SeleniumHQ:trunk Jul 29, 2020
titusfortner pushed a commit to titusfortner/selenium that referenced this pull request Aug 13, 2020
* [JS] Kill opera service on quit

* [JS] Reverting doc comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants