[Navigation] Return early from NavigatorProvider#addNavigator if possible - #176
Closed
jossiwolf wants to merge 1 commit into
Closed
Conversation
…tor are equal We want to return early from `addNavigator` if the previous and to-be-added navigator are equal. This allows calling `addNavigator` as a side effect of every composition without having to worry about the Navigator being replaced every time. Test: Added addExistingNavigatorDoesntReplace and addWithSameNameButUnequalNavigatorDoesReplace in NavigatorProviderTest.kt Fixes: b/187443146 Change-Id: Id09b7e3306c49f261b80c724d36c614671f5a7ac
ianhanniballake
approved these changes
May 7, 2021
harryzz
pushed a commit
to harryzz/compose-multiplatform-core
that referenced
this pull request
Jul 28, 2026
… possible We want to return early from `addNavigator` if the previous and to-be-added navigator are equal. This allows calling `addNavigator` as a side effect of every composition without having to worry about the Navigator being replaced every time. Test: Added addExistingNavigatorDoesntReplace and addWithSameNameButUnequalNavigatorDoesReplace in NavigatorProviderTest.kt Fixes: b/187443146 Change-Id: Id09b7e3306c49f261b80c724d36c614671f5a7ac This is an imported pull request from androidx#176. Resolves JetBrains#176 Github-Pr-Head-Sha: ba934c5 GitOrigin-RevId: 471dbf4 Change-Id: I5aefe997aaaf41f5080895c9c8cfcd6c83282eea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to return early from
addNavigatorif the previous and to-be-added navigator are equal. This allows callingaddNavigatoras a side effect of every composition without having to worry about the Navigator being replaced every time.Test: Added addExistingNavigatorDoesntReplace and addWithSameNameButUnequalNavigatorDoesReplace in NavigatorProviderTest.kt
Fixes: b/187443146
Change-Id: Id09b7e3306c49f261b80c724d36c614671f5a7ac