[Navigation] Fix tests in NavDeepLinkTest - #210
Closed
osipxd wants to merge 1 commit into
Closed
Conversation
Contributor
|
Hi Osip, looks like you are failing a Presubmit check. Looks like you may just need to update and re-sync your gradle. |
osipxd
force-pushed
the
fix-nav-deep-link-tests
branch
from
July 19, 2021 20:48
cb5eadf to
791c0b0
Compare
Contributor
Author
|
@sanura-njaka, yes, I see. But I don't understand how changes in tests in module |
Contributor
|
I'll take a look, might be an issue on our end! |
Contributor
|
Turns out this was an issue on our end - it should be fixed now, can you rebase and try again? Sorry about the back and forth. |
Signed-off-by: Osip Fatkullin <osip.fatkullin@gmail.com>
osipxd
force-pushed
the
fix-nav-deep-link-tests
branch
from
July 21, 2021 09:48
791c0b0 to
642e2a2
Compare
Contributor
Author
|
@dlam, Done |
sanura-njaka
approved these changes
Jul 27, 2021
sanura-njaka
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thanks for separating this out!
dlam
approved these changes
Jul 28, 2021
harryzz
pushed a commit
to harryzz/compose-multiplatform-core
that referenced
this pull request
Jul 28, 2026
There were tests that actually did not what was declared in assert. ## Testing Test: ./gradlew connectedCheck This is an imported pull request from androidx#210. Resolves JetBrains#210 Github-Pr-Head-Sha: 642e2a2 GitOrigin-RevId: d3e202a Change-Id: I5d5ce1a5a5e61f984bfb6022ca6c5dd261d3020e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were tests that actually did not what was declared in assert.
Testing
Test: ./gradlew connectedCheck