This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-300] Fix ndarray assignment bug with index -1#10468
Merged
piiswrong merged 2 commits intoapache:masterfrom Apr 10, 2018
Merged
[MXNET-300] Fix ndarray assignment bug with index -1#10468piiswrong merged 2 commits intoapache:masterfrom
piiswrong merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
Thanks for the fix. Could you add the test cases here as it's more comprehensive and generic than the legacy one? |
Contributor
Author
|
@reminisce Sure, I'll do. |
Contributor
Author
|
@reminisce I added some cases covering this PR (negative index in basic indexing) and removed two duplicated cases. |
reminisce
approved these changes
Apr 10, 2018
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* Fix ndarray assignment bug with index -1 * Add test cases for negative index
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* Fix ndarray assignment bug with index -1 * Add test cases for negative index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a sequel of PR #10440. I missed that there is a same kind of bug with the assignment. For example, the following code causes an error. This PR fixes it.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.