Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Updating news, readme files and bumping master version to 1.3.1#12525

Merged
szha merged 3 commits intoapache:masterfrom
Roshrini:news_update
Sep 17, 2018
Merged

Updating news, readme files and bumping master version to 1.3.1#12525
szha merged 3 commits intoapache:masterfrom
Roshrini:news_update

Conversation

@Roshrini
Copy link
Member

@Roshrini Roshrini commented Sep 12, 2018 •
edited
Loading

Description

As title
Please do not merge until after the release.
@szha

@gigasquid I did not include clojure files here as I was not sure about them. Can you please point those out?

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@gigasquid
Copy link
Member

gigasquid commented Sep 12, 2018

Thanks for putting this together @Roshrini.
The version number is located in the project.clj files in the Clojure package.

I'd be happy to put a separate PR together for it if you prefer.

@Roshrini Roshrini requested a review from gigasquid as a code owner September 12, 2018 19:44
@Roshrini
Copy link
Member Author

Roshrini commented Sep 12, 2018

@gigasquid Updated clojure files.

@Roshrini Roshrini changed the title [WIP] Updating news, readme files and bumping master version to 1.3.1 Updating news, readme files and bumping master version to 1.3.1 Sep 12, 2018
gigasquid
gigasquid approved these changes Sep 13, 2018
View reviewed changes
Copy link
Member

@gigasquid gigasquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the clojure package and it looks great 💯

@kalyc
Copy link
Contributor

kalyc commented Sep 14, 2018

Thanks for your contribution @Roshrini
@mxnet-label-bot[pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Sep 14, 2018
@szha szha merged commit 9032e93 into apache:master Sep 17, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
@Roshrini @anirudh2290
Updating news, readme files and bumping master version to 1.3.1 (apac…
d6b888b 
…he#12525)

* news, readme update on master

* Bumping version on master

* clojure files version updated
@Roshrini Roshrini deleted the news_update branch November 15, 2018 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

@thirdwing thirdwing Awaiting requested review from thirdwing thirdwing is a code owner

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

1 more reviewer

@gigasquid gigasquid gigasquid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Roshrini @gigasquid @kalyc @szha @marcoabreu