This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-1385] Improved Scala Init and Macros warning messages#14656
Merged
lanking520 merged 4 commits intoapache:masterfrom Apr 19, 2019
Merged
[MXNET-1385] Improved Scala Init and Macros warning messages#14656lanking520 merged 4 commits intoapache:masterfrom
lanking520 merged 4 commits intoapache:masterfrom
Conversation
zachgk
reviewed
Apr 10, 2019
scala-package/macros/src/main/scala/org/apache/mxnet/APIDocGenerator.scala
Show resolved
Hide resolved
scala-package/macros/src/main/scala/org/apache/mxnet/GeneratorBase.scala
Outdated
Show resolved
Hide resolved
c5daa53 to
41f2cff
Compare
zachgk
approved these changes
Apr 12, 2019
aaronmarkham
suggested changes
Apr 15, 2019
Contributor
aaronmarkham
left a comment
There was a problem hiding this comment.
Can you be consistent with sentence capitalization? I think when displayed in the docs it'll look better if the doc strings are formatted consistently.
Can you flag functions and params with ticks?
Can you cross link to other functions' or params' docs? (not sure if this is possible)
scala-package/macros/src/main/scala/org/apache/mxnet/utils/CToScalaUtils.scala
Outdated
Show resolved
Hide resolved
scala-package/macros/src/main/scala/org/apache/mxnet/utils/CToScalaUtils.scala
Outdated
Show resolved
Hide resolved
scala-package/macros/src/main/scala/org/apache/mxnet/GeneratorBase.scala
Outdated
Show resolved
Hide resolved
scala-package/init/src/main/scala/org/apache/mxnet/init/Base.scala
Outdated
Show resolved
Hide resolved
41f2cff to
7f65538
Compare
aaronmarkham
suggested changes
Apr 18, 2019
Contributor
aaronmarkham
left a comment
There was a problem hiding this comment.
Found some leftover formatting issues... I'm seeing isContrib in a lot of places that probably should be formatted too.
scala-package/init/src/main/scala/org/apache/mxnet/init/LibInfo.scala
Outdated
Show resolved
Hide resolved
scala-package/init/src/main/scala/org/apache/mxnet/init/LibInfo.scala
Outdated
Show resolved
Hide resolved
scala-package/init/src/main/scala/org/apache/mxnet/init/LibInfo.scala
Outdated
Show resolved
Hide resolved
scala-package/init/src/main/scala/org/apache/mxnet/init/LibInfo.scala
Outdated
Show resolved
Hide resolved
scala-package/init/src/main/scala/org/apache/mxnet/init/LibInfo.scala
Outdated
Show resolved
Hide resolved
scala-package/init/src/main/scala/org/apache/mxnet/init/LibInfo.scala
Outdated
Show resolved
Hide resolved
scala-package/macros/src/main/scala/org/apache/mxnet/SymbolMacro.scala
Outdated
Show resolved
Hide resolved
scala-package/macros/src/main/scala/org/apache/mxnet/SymbolMacro.scala
Outdated
Show resolved
Hide resolved
scala-package/macros/src/main/scala/org/apache/mxnet/SymbolMacro.scala
Outdated
Show resolved
Hide resolved
scala-package/macros/src/main/scala/org/apache/mxnet/NDArrayMacro.scala
Outdated
Show resolved
Hide resolved
7f65538 to
085649f
Compare
aaronmarkham
approved these changes
Apr 19, 2019
kedarbellare
pushed a commit
to kedarbellare/incubator-mxnet
that referenced
this pull request
Apr 20, 2019
…14656) * 1st phase scala/java warning killers * add more comments * Capitialize all starting words of comments * amend the rest of them
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
…14656) * 1st phase scala/java warning killers * add more comments * Capitialize all starting words of comments * amend the rest of them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add comprehensive comments on Init and Macros stage for Scala build to get rid of Scala docs warning.
@zachgk @andrewfayres @piyushghai @aaronmarkham
This is the phase 1 for #14081
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.