This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Add Sparse NDArray support for Scala#15378
Merged
lanking520 merged 6 commits intoapache:masterfrom Jul 8, 2019
Merged
Conversation
5e1c97a to
ed00cc1
Compare
| @@ -45,6 +45,22 @@ class NDArraySuite extends FunSuite with BeforeAndAfterAll with Matchers { | |||
| assert(ndones.toScalar === 1f) | |||
| } | |||
|
|
|||
Member
There was a problem hiding this comment.
can we also test ndarray iterator with csr_matrix?
zachgk
reviewed
Jun 28, 2019
scala-package/core/src/main/scala/org/apache/mxnet/SparseNDArray.scala
Outdated
Show resolved
Hide resolved
zachgk
approved these changes
Jul 2, 2019
frankfliu
pushed a commit
to frankfliu/incubator-mxnet
that referenced
this pull request
Aug 19, 2019
* add Sparse Support * add imperative invoke sparse support * add retain method and comments * add getData method * add Sparse NDIter test * remove debug line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the initial PR to start supporting Sparse
NDArrayfor the Scala package.SparseNDArrayis a child class of MXNet NDArray. It supports the following types:Currently, users can call
toSparsemethod to convert aNDArrayfrom dense to sparse or cast aNDArraytoSparseNDArray. User can also call the following two methods to create Sparse NDArray from scratchSparseNDArray.csrMatrixSparseNDArray.rowSparseArray@gigasquid @zachgk @yzhliu @nswamy @eric-haibin-lin @frankfliu
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments