This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Add magic method abs to NDArray and Symbol.#15680
Merged
wkcn merged 7 commits intoapache:masterfrom Aug 2, 2019
Merged
Conversation
wkcn
approved these changes
Jul 29, 2019
Member
There was a problem hiding this comment.
LGTM. Thank you : )
Could you please add __abs__ for class Symbol in python/mxnet/symbol/symbol.py too? Thx!
1316651 to
6e64ee9
Compare
Contributor
Author
|
@wkcn Have updated the code. Please review. |
Member
|
@kshitij12345 Great! LGTM. Thanks for your contribution! |
Contributor
Author
|
@wkcn The update for 1 CI check shows that it is pending, however its details show that it has completed successfully. Should I retrigger the CI or is that okay? |
Member
|
@kshitij12345 I have retriggered it : ) |
…to develop/ndarray/abs-magic-method
Contributor
|
@mxnet-label-bot Add [pr-awaiting-merge, NDarray] |
apeforest
approved these changes
Jul 31, 2019
Contributor
apeforest
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution
piyushghai
approved these changes
Jul 31, 2019
abs to NDArray.abs to NDArray and Symbol.
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
* add magic method abs to ndarray * add relevant tests * add magic method abs to symbol * add relevant tests * retrigger CI * retrigger CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This magic method was missing.
Allow the natural
abs(x).Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
absmagic method.