This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Allow operators with multiple outputs in get_atomic_symbol#15740
Merged
ptrendx merged 2 commits intoapache:masterfrom Aug 13, 2019
Merged
Allow operators with multiple outputs in get_atomic_symbol#15740ptrendx merged 2 commits intoapache:masterfrom
ptrendx merged 2 commits intoapache:masterfrom
Conversation
b43360f to
11834a2
Compare
DickJC123
approved these changes
Aug 13, 2019
Contributor
DickJC123
left a comment
There was a problem hiding this comment.
For whatever it's worth, I have verified that this test fails on the codebase without this PR.
This PR LGTM.
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
joapolarbear
added a commit
to joapolarbear/incubator-mxnet
that referenced
this pull request
Oct 28, 2020
joapolarbear
added a commit
to joapolarbear/incubator-mxnet
that referenced
this pull request
Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for #15725. Previously the implementation required that number of outputs in the source symbol was 1, which is too strong requirement (as what it actually requires is that the symbol is not a symbol group). This PR fixes that to allow single symbols with multiple outputs.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.