Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Implements ldexp operator#15845

Merged
reminisce merged 1 commit intoapache:numpy_prsfrom
ckt624:master_ldexp
Sep 24, 2019
Merged

[Numpy] Implements ldexp operator#15845
reminisce merged 1 commit intoapache:numpy_prsfrom
ckt624:master_ldexp

Conversation

@ckt624
Copy link
Contributor

@ckt624 ckt624 commented Aug 10, 2019

Description

See https://docs.scipy.org/doc/numpy/reference/generated/numpy.ldexp.html

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Implements ldexp

Comments

@haojin2 @reminisce

@ckt624 ckt624 requested a review from szha as a code owner August 10, 2019 08:46
@haojin2 haojin2 added the Numpy label Aug 10, 2019
@haojin2 haojin2 self-assigned this Aug 10, 2019
@haojin2 haojin2 requested review from haojin2 and reminisce and removed request for szha August 10, 2019 09:10
@ckt624 ckt624 force-pushed the master_ldexp branch 7 times, most recently from 047828a to eca118b Compare August 14, 2019 04:19
haojin2
haojin2 reviewed Aug 14, 2019
View reviewed changes
@ckt624 ckt624 force-pushed the master_ldexp branch 4 times, most recently from ea41a01 to 57491e4 Compare August 19, 2019 07:40
@reminisce reminisce changed the base branch from master to numpy_prs September 24, 2019 19:19
@ckt624 @reminisce
Implements ldexp.
fe30d94 
Remove spaces.

Change tests.

Reorganize files.

Change styles.

Add spaces
@reminisce reminisce merged commit 3e4a2a4 into apache:numpy_prs Sep 24, 2019
@reminisce reminisce mentioned this pull request Oct 5, 2019
Merged
7 tasks
reminisce pushed a commit that referenced this pull request Oct 5, 2019
@ckt624 @reminisce
Implements ldexp. (#15845)
adf288c 
Remove spaces.

Change tests.

Reorganize files.

Change styles.

Add spaces
reminisce pushed a commit that referenced this pull request Oct 6, 2019
@ckt624 @reminisce
Implements ldexp. (#15845)
c5005e4 
Remove spaces.

Change tests.

Reorganize files.

Change styles.

Add spaces
reminisce pushed a commit that referenced this pull request Oct 7, 2019
@ckt624 @reminisce
Implements ldexp. (#15845)
09285c8 
Remove spaces.

Change tests.

Reorganize files.

Change styles.

Add spaces
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@reminisce reminisce Awaiting requested review from reminisce

1 more reviewer

@haojin2 haojin2 haojin2 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@haojin2 haojin2

Labels

Numpy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ckt624 @haojin2 @reminisce