Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Numpy Operators: Inner, Outer, vdot#15846

Merged
reminisce merged 2 commits intoapache:numpy_prsfrom
ckt624:master_outer
Sep 24, 2019
Merged

Numpy Operators: Inner, Outer, vdot#15846
reminisce merged 2 commits intoapache:numpy_prsfrom
ckt624:master_outer

Conversation

@ckt624
Copy link
Contributor

@ckt624 ckt624 commented Aug 10, 2019

Description

Implements np.inner, np.outer, and np.vdot
https://docs.scipy.org/doc/numpy/reference/generated/numpy.inner.html#numpy.inner
https://docs.scipy.org/doc/numpy/reference/generated/numpy.outer.html#numpy.outer
https://docs.scipy.org/doc/numpy/reference/generated/numpy.vdot.html#numpy.vdot

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Implements np.inner
  • Implements np.outer
  • Implements np.vdot

Comments

@haojin2 @reminisce

@ckt624 ckt624 requested a review from szha as a code owner August 10, 2019 09:31
@ckt624 ckt624 force-pushed the master_outer branch 2 times, most recently from 037bb5e to 788e8ce Compare August 14, 2019 05:16
haojin2
haojin2 reviewed Aug 14, 2019
View reviewed changes
haojin2
haojin2 approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the style fixes.

@ckt624 ckt624 force-pushed the master_outer branch 2 times, most recently from aa45110 to f1dcaa6 Compare August 19, 2019 07:40
@reminisce reminisce changed the base branch from master to numpy_prs September 24, 2019 19:58
ckt624 and others added 2 commits September 24, 2019 13:31
@ckt624 @reminisce
Implements tensordot and dot.
9f605fb 
Change tests.

Add spaces.

Reorganize codes.

Implements inner, outer, vdot.

Remove spaces.

Change tests.

change test format.

Change indent.

Change styles
@reminisce
Fix
0995ea7
@reminisce reminisce merged commit f3f6b1d into apache:numpy_prs Sep 24, 2019
@reminisce reminisce mentioned this pull request Oct 5, 2019
Merged
7 tasks
reminisce pushed a commit that referenced this pull request Oct 5, 2019
@ckt624 @reminisce
Numpy Operators: Inner, Outer, vdot (#15846)
dda90dd 
* Implements tensordot and dot.

Change tests.

Add spaces.

Reorganize codes.

Implements inner, outer, vdot.

Remove spaces.

Change tests.

change test format.

Change indent.

Change styles

* Fix
reminisce pushed a commit that referenced this pull request Oct 6, 2019
@ckt624 @reminisce
Numpy Operators: Inner, Outer, vdot (#15846)
fbfb7d3 
* Implements tensordot and dot.

Change tests.

Add spaces.

Reorganize codes.

Implements inner, outer, vdot.

Remove spaces.

Change tests.

change test format.

Change indent.

Change styles

* Fix
reminisce pushed a commit that referenced this pull request Oct 7, 2019
@ckt624 @reminisce
Numpy Operators: Inner, Outer, vdot (#15846)
2df3282 
* Implements tensordot and dot.

Change tests.

Add spaces.

Reorganize codes.

Implements inner, outer, vdot.

Remove spaces.

Change tests.

change test format.

Change indent.

Change styles

* Fix
reminisce added a commit to reminisce/mxnet that referenced this pull request Oct 9, 2019
@reminisce
Revert "Numpy Operators: Inner, Outer, vdot (apache#15846)"
79ceaa7 
This reverts commit 2df3282.
reminisce added a commit to reminisce/mxnet that referenced this pull request Oct 9, 2019
@reminisce
Revert "Revert "Numpy Operators: Inner, Outer, vdot (apache#15846)""
b05b630 
This reverts commit 79ceaa7.
reminisce added a commit that referenced this pull request Oct 10, 2019
@reminisce
Fix windows flakiness (#16415)
9ff644b 
* Revert "Numpy det and slogdet operators (#15861)"

This reverts commit 295fc14.

* Delete non-windows test

* Revert "Numpy Operators: Inner, Outer, vdot (#15846)"

This reverts commit 2df3282.

* Revert "Revert "Numpy Operators: Inner, Outer, vdot (#15846)""

This reverts commit 79ceaa7.

* Revert "Delete non-windows test"

This reverts commit c915877.
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
@reminisce @aaronmarkham
Fix windows flakiness (apache#16415)
d948256 
* Revert "Numpy det and slogdet operators (apache#15861)"

This reverts commit 295fc14.

* Delete non-windows test

* Revert "Numpy Operators: Inner, Outer, vdot (apache#15846)"

This reverts commit 2df3282.

* Revert "Revert "Numpy Operators: Inner, Outer, vdot (apache#15846)""

This reverts commit 79ceaa7.

* Revert "Delete non-windows test"

This reverts commit c915877.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha

1 more reviewer

@haojin2 haojin2 haojin2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Numpy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ckt624 @haojin2 @reminisce