This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Merged
Conversation
haojin2
reviewed
Aug 15, 2019
haojin2
reviewed
Aug 15, 2019
haojin2
reviewed
Aug 15, 2019
sxjscience
reviewed
Sep 11, 2019
sxjscience
suggested changes
Sep 11, 2019
sxjscience
reviewed
Sep 12, 2019
sxjscience
reviewed
Sep 15, 2019
| expected_np = _np.copysign(a1_np, a2_np) | ||
| with mx.autograd.record(): | ||
| mx_out = test_copysign(a1, a2) | ||
| assert mx_out.shape == expected_np.shape |
Member
There was a problem hiding this comment.
Test if mx_out.dtype matches expected_np.dtype. I think we can later add a utility to match the shape + dtype.
Member
There was a problem hiding this comment.
Ignore my previous comments. I think we'd better check the return types after we support arbitrary dtype combinations in deepnumpy. So it's okay to not check the return types now.
Contributor
Author
There was a problem hiding this comment.
I agree that in the future we should do it, after more dtypes and casting is supported.
sxjscience
approved these changes
Sep 15, 2019
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
* add numpy compatible copysign * fix scalar op registration error * add test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Numpy compatible copysign
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments