This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Discard needless test cases in test_convolution_independent_gradients#15939
Merged
pengzhao-intel merged 3 commits intoapache:masterfrom Aug 20, 2019
xziya:reduce-ut-cost
Merged
Discard needless test cases in test_convolution_independent_gradients#15939pengzhao-intel merged 3 commits intoapache:masterfrom xziya:reduce-ut-cost
test_convolution_independent_gradients#15939pengzhao-intel merged 3 commits intoapache:masterfrom
xziya:reduce-ut-cost
Conversation
Contributor
|
The runtime of MKLDNN is slower than the original build? |
Contributor
Author
|
Convolution with MKL-DNN contains the warm-up cost in test. So I think it might take more time to prepare memory and run into the convolution primitive. |
Contributor
Author
|
@pengzhao-intel CI has passed. Please take some reviews on it. Thanks. |
pengzhao-intel
approved these changes
Aug 20, 2019
Contributor
pengzhao-intel
left a comment
There was a problem hiding this comment.
LGTM and merging now.
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
…s` (apache#15939) * Drop needless num_bases in test of conv * Trigger CI * Re-trigger CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_operator.test_convolution_independent_gradientsmay cost too much occasionally, leading to terminated failed CIs. As it was discussed in ISSUE #15880,test_random.test_shufflewas also time-consuming, which has been already fixed by PR #15922. This PR aims to reduce the cost oftest_convolution_independent_gradientsby discarding some needless test cases. @pengzhao-intel @ciyongch @TaoLvChecklist
Changes
Performance