This repository was archived by the owner on Nov 17, 2023. It is now read-only.
MKL-DNN RNN checks NDArray version#16071
Merged
pengzhao-intel merged 3 commits intoapache:masterfrom Sep 4, 2019
Merged
Conversation
Contributor
Author
|
Hi, @matteosal. This PR aims to fix the problem filed by #16037. Hope it could work. Would you mind checking on this branch to see whether it works for your cases? It will be very helpful. Thanks. |
Contributor
|
Tested, it fixes the issue |
Contributor
Author
Thanks a lot 🙂. |
Contributor
Author
|
CI passed. Please take a look @PatricZhao @ciyongch |
Contributor
|
@ciyongch please help take a reveiw |
pengzhao-intel
approved these changes
Sep 4, 2019
Contributor
pengzhao-intel
left a comment
There was a problem hiding this comment.
Thanks for the quick fix. Merging now.
gyshi
pushed a commit
to gyshi/incubator-mxnet
that referenced
this pull request
Sep 7, 2019
* MKL-DNN RNN checks NDArray version * Add UT * Use default_context()
gyshi
pushed a commit
to gyshi/incubator-mxnet
that referenced
this pull request
Sep 7, 2019
* MKL-DNN RNN checks NDArray version * Add UT * Use default_context()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This should fix ISSUE #16037. A member variable
weights_versionis added toRNNOpclass. Besides, instead of usingStorage::Handleto hold the temp space, this PR turns to useNDArrayfor the management of temp space. @ciyongch @PatricZhao @TaoLv @ZhennanQinChecklist
Changes
NDArray.version()) check, unit test addedStorage::Handle->NDArray