Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Clojure: Support MKLDNN subgraph backend in tests#16117

Merged
gigasquid merged 1 commit intoapache:masterfrom
AlexChalk:adc/fix-same-data-name-error
Sep 9, 2019
Merged

Clojure: Support MKLDNN subgraph backend in tests#16117
gigasquid merged 1 commit intoapache:masterfrom
AlexChalk:adc/fix-same-data-name-error

Conversation

@AlexChalk
Copy link
Contributor

@AlexChalk AlexChalk commented Sep 8, 2019

Description

When the MKLDNN subgraph backend is enabled, subgraph assumes that any input variables have unique names. To avoid failing tests in this scenario, this PR replaces such non-unique variable names with unique ones in the Clojure test suite.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change.

Changes

  • Remove non-unique variable names from test suite.

Comments

Example error message when unique variable names are not used:

actual: org.apache.mxnet.MXNetError: [01:57:41] src/executor/graph_executor.cc:1847: Check failed: arg_names.size() == in_args_map.size() (2 vs. 1) :
Stack trace:
  [bt] (0) /tmp/mxnet4687853178926540653/libmxnet.so(+0x2ac5eb) [0x7fb8f7f495eb]
  [bt] (1) /tmp/mxnet4687853178926540653/libmxnet.so(+0x2be36e8) [0x7fb8fa8806e8]
  [bt] (2) /tmp/mxnet4687853178926540653/libmxnet.so(mxnet::Executor::Bind(nnvm::Symbol, mxnet::Context const&, std::map<std::string, mxnet::Context, std::less<std::string>, std::allocator<std::pair<std::string const, mxnet::Context> > > const&, std::vector<mxnet::NDArray, std::allocator<mxnet::NDArray> > const&, std::vector<mxnet::NDArray, std::allocator<mxnet::NDArray> > const&, std::vector<mxnet::OpReqType, std::allocator<mxnet::OpReqType> > const&, std::vector<mxnet::NDArray, std::allocator<mxnet::NDArray> > const&, mxnet::Executor*)+0x7ad) [0x7fb8fa894c3d]
  [bt] (3) /tmp/mxnet4687853178926540653/libmxnet.so(MXExecutorBindEX+0x97b) [0x7fb8fa7cf52b]
  [bt] (4) /tmp/mxnet4687853178926540653/mxnet-scala(Java_org_apache_mxnet_LibInfo_mxExecutorBindEX+0x220) [0x7fb9297a0f00]
  [bt] (5) [0x7fb939018427]

Related to #16106.

@AlexChalk AlexChalk requested a review from gigasquid as a code owner September 8, 2019 03:32
pengzhao-intel
pengzhao-intel approved these changes Sep 8, 2019
View reviewed changes
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements. LGTM.

gigasquid
gigasquid approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@gigasquid gigasquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 💯

@gigasquid gigasquid merged commit 9a9c5f8 into apache:master Sep 9, 2019
@AlexChalk AlexChalk deleted the adc/fix-same-data-name-error branch September 11, 2019 00:22
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
@AlexChalk @larroy
Fix failing tests (apache#16117)
010dbc2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@gigasquid gigasquid gigasquid approved these changes

@pengzhao-intel pengzhao-intel pengzhao-intel approved these changes

@ZhennanQin ZhennanQin ZhennanQin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Clojure MKLDNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexChalk @gigasquid @pengzhao-intel @ZhennanQin