This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Add exception check for numpy reshape#16180
Merged
sxjscience merged 1 commit intoapache:masterfrom Sep 18, 2019
Merged
Conversation
Member
Author
samskalicky
approved these changes
Sep 16, 2019
Contributor
samskalicky
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick fix!
zachgk
approved these changes
Sep 16, 2019
anirudh2290
approved these changes
Sep 16, 2019
Member
anirudh2290
left a comment
There was a problem hiding this comment.
This looks good. having said that this still wont help with the related issue if it is only happening on macos since we dont have tests for macos currently on the CI.
reminisce
approved these changes
Sep 16, 2019
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Try to add exception to avoid error-message downgrade issues reported in #16102
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments