Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Fixing links for website + Fixing search#16284

Merged
ThomasDelteil merged 9 commits intoapache:masterfrom
ThomasDelteil:new_website_fixing_links
Sep 27, 2019
Merged

Fixing links for website + Fixing search#16284
ThomasDelteil merged 9 commits intoapache:masterfrom
ThomasDelteil:new_website_fixing_links

Conversation

@ThomasDelteil
Copy link
Contributor

@ThomasDelteil ThomasDelteil commented Sep 26, 2019 •
edited
Loading

Description

  • added back sparse tutorials, embedded tutorials, tensorRT, mkldnn, onnx, amp
  • fixed search
  • fixed links

@ThomasDelteil ThomasDelteil mentioned this pull request Sep 26, 2019
Closed
7 tasks
@vishaalkapoor
Copy link
Contributor

vishaalkapoor commented Sep 26, 2019 •
edited
Loading

@ThomasDelteil Should we be using mxnet.incubator.apache.org or mxnet.apache.org for the links? As per https://issues.apache.org/jira/browse/INFRA-19144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938269#comment-16938269
If this is a requirement, then s/mxnet.incubator.apache.org/mxnet.apache.org/g

sojiadeshina
sojiadeshina approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@sojiadeshina sojiadeshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes @ThomasDelteil. super crucial that we get this merged in asap and have the new website in better state for users.

sojiadeshina
sojiadeshina reviewed Sep 26, 2019
View reviewed changes
aaronmarkham
aaronmarkham suggested changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handful of suggestions. We can hit this in multiple passes, but highlighting the https updates shined a light on how the links need tweaking...

@ThomasDelteil
Copy link
Contributor Author

ThomasDelteil commented Sep 27, 2019 •
edited
Loading

@marcoabreu I don't think there's a special reason why links have been added in absolute way vs a relative way. Absolute links way makes it easier to have effective redirects, but as you mentioned they are indeed domain dependent and it becomes a problem if we test on a different domain. Relative links makes it easy to change domain.
The current set of updates focus on fixing the links rather than updating them all to be relative vs absolute which is a whole other beast. This update took care of ~30 links / 150+ broken ones. I think priority right now should be given to fixing the links, and the next update can focus on standardizing them.

@ThomasDelteil ThomasDelteil merged commit 8004a02 into apache:master Sep 27, 2019
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
@ThomasDelteil @larroy
Fixing links for website + Fixing search (apache#16284)
a4e8343 
* first updates

* fixing links + adding tutorials

* fix search

* fixing more links and adding new tutorials

* wrong license edit

* fix rendering

* Apply suggestions from code review

Co-Authored-By: Aaron Markham <markhama@amazon.com>

* moving mxnet.incubator.apache.org to mxnet.apache.org as per Apache infra for better indexing  https://issues.apache.org/jira/browse/INFRA-19144

* fixing line too long
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin eric-haibin-lin is a code owner

@gigasquid gigasquid Awaiting requested review from gigasquid gigasquid is a code owner

@iblislin iblislin Awaiting requested review from iblislin

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

@sergeykolychev sergeykolychev Awaiting requested review from sergeykolychev sergeykolychev is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

3 more reviewers

@sojiadeshina sojiadeshina sojiadeshina approved these changes

@aaronmarkham aaronmarkham aaronmarkham approved these changes

@vishaalkapoor vishaalkapoor vishaalkapoor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ThomasDelteil @vishaalkapoor @aaronmarkham @sojiadeshina @marcoabreu