This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Minor type issues in Squeeze#16448
Merged
eric-haibin-lin merged 4 commits intoapache:masterfrom Oct 13, 2019
Merged
Conversation
zheng-da
approved these changes
Oct 12, 2019
Member
eric-haibin-lin
left a comment
There was a problem hiding this comment.
Can we add a test case where the original code fails? (e.g. nd.squeeze(ones, 1))
Member
Author
|
I see...I didn't realize that it fixes an issue that @zheng-da and @eric-haibin-lin mentioned before...I will add a testcase... |
Member
|
@junrushao1994 you're the man! |
aaronmarkham
pushed a commit
to aaronmarkham/incubator-mxnet
that referenced
this pull request
Oct 16, 2019
* minor * test * Retrigger * Retrigger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zheng-da
This issue caused an incorrect type signature in our auto-generated C++ wrapper in CPP package, link.
With this bug exists, the cpp-package would generate the first argument of signature
const std::vector<Symbol> &, but the correct one should beconst Symbol &.Update: as Haibin and Da mentions, this is also the root of the following bug: