Fix sparse search #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the pull request. Indeed as mentioned in #60, this is an error that sadly I wasn't able to find earlier myself. Kind Regards, |
wisebayes
pushed a commit
to wisebayes/beir
that referenced
this pull request
May 7, 2025
Fix sparse search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request fixes two issues with the sparse search:
trange, some queries are never evaluated (only the first one of each batch is evaluated) as reported in Error inbeir/beir/retrieval/search/sparse/sparse_search.py#60.Let me know if you have any questions.
Maxime.