[iOS] CarouselView with CarouselViewHandler2 make app crash when Loop="False" and user scroll to the last position - fix#26868
Merged
PureWeen merged 2 commits intodotnet:inflight/currentfrom Jun 9, 2025
Conversation
Contributor
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
mattleibow
reviewed
Jan 6, 2025
Member
mattleibow
left a comment
There was a problem hiding this comment.
This looks sensible, is it possible to add a test for this? I feel like a device test that just renders the CV should trigger this?
Can you set the position via code, or does the user have to scroll manually for this to occur?
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
@mattleibow added :) |
Member
|
/azp run |
rmarinho
approved these changes
Jan 7, 2025
This comment was marked as outdated.
This comment was marked as outdated.
rmarinho
previously requested changes
Jan 7, 2025
Member
rmarinho
left a comment
There was a problem hiding this comment.
Seems the test is failing
AppShouldNotCrashOnScrollingCarouselViewWithoutLoop
0cf6808 to
a913297
Compare
Contributor
Author
|
@rmarinho can we try again? |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
This also fixes phantom items in carousel with 1-2 elements when loop = false (without the fix, the binded items are followed by their "broken" clones at the end of the carousel) |
Did you find any workaround? |
Contributor
Author
|
Hi! @CleverSoftwarePoland, I don't know when it will make it into release but you can ask @rmarinho |
|
Any plans to try again to pass tests or we have to search for other solution? As right now CarouselViewHandler2 is broken when set to loop = false |
|
@rmarinho @jfversluis |
Member
|
@seanrodda what is always useful is to test the changes in a PR and let us know if that resolves your issue. Instructions for that can be found here: https://github.com/dotnet/maui/wiki/Testing-PR-Builds |
|
@jfversluis Thanks. The build doesn't exist on the build pipeline from the PR, however I have copied the code changes for the change locally and can confirm it fixes the crash when loop = false fixes the phantom items issue @Bamich mentioned above. |
jfversluis
approved these changes
Apr 22, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
…="False" and user scroll to the last position - fix (#26868) * Update CarouselViewController2.cs * Added a UI test for Matt
kubaflo
added a commit
to kubaflo/maui
that referenced
this pull request
Jun 11, 2025
…="False" and user scroll to the last position - fix (dotnet#26868) * Update CarouselViewController2.cs * Added a UI test for Matt
github-actions bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
…="False" and user scroll to the last position - fix (#26868) * Update CarouselViewController2.cs * Added a UI test for Matt
github-actions bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
…="False" and user scroll to the last position - fix (#26868) * Update CarouselViewController2.cs * Added a UI test for Matt
PureWeen
pushed a commit
that referenced
this pull request
Jun 21, 2025
…="False" and user scroll to the last position - fix (#26868) * Update CarouselViewController2.cs * Added a UI test for Matt
PureWeen
pushed a commit
that referenced
this pull request
Jun 25, 2025
…="False" and user scroll to the last position - fix (#26868) * Update CarouselViewController2.cs * Added a UI test for Matt
PureWeen
pushed a commit
that referenced
this pull request
Jun 25, 2025
…="False" and user scroll to the last position - fix (#26868) * Update CarouselViewController2.cs * Added a UI test for Matt
github-actions bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
…="False" and user scroll to the last position - fix (#26868) * Update CarouselViewController2.cs * Added a UI test for Matt
github-actions bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
…="False" and user scroll to the last position - fix (#26868) * Update CarouselViewController2.cs * Added a UI test for Matt
PureWeen
pushed a commit
that referenced
this pull request
Jun 27, 2025
…="False" and user scroll to the last position - fix (#26868) * Update CarouselViewController2.cs * Added a UI test for Matt
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
…="False" and user scroll to the last position - fix (#26868) * Update CarouselViewController2.cs * Added a UI test for Matt
PureWeen
pushed a commit
that referenced
this pull request
Jun 27, 2025
…="False" and user scroll to the last position - fix (#26868) * Update CarouselViewController2.cs * Added a UI test for Matt
PureWeen
added a commit
that referenced
this pull request
Jun 28, 2025
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes - Inflight/Candidate Branch ## What's Changed ### MAUI Product Fixes * [iOS] CarouselView with CarouselViewHandler2 make app crash when Loop="False" and user scroll to the last position - fixes #26863 by @kubaflo in #26868 * Fixes Setting BackgroundColor to null does not actually changes BackgroundColor - fixes #22914 and #19576 by @jgonzalez-gft in #22917 * Fixed the picker title's color - fixes #16737 by @kubaflo in #23075 * [android] Fallback to default icons in SearchHandler by @aheubusch in #25067 * ScrollView's Background on iOS - fixes #24016 by @kubaflo in #25541 * [iOS] Enabled MultiTouch Support for Handling Multi-Touch Points in GraphicsView - fixes #29461 by @prakashKannanSf3972 in #29895 * Optimize converters for GridLength, ColumnDefinition, and RowDefinition - performance improvement by @emiller in #20048 * Add defensive IsAlive check to Android ViewExtensions.OnUnloaded - fixes #28051 by @jfversluis in #29934 * [Windows] Fixed runtime update issue for SearchBar PlaceholderColor and BackgroundColor - fixes #29962 by @Tamilarasan-Paranthaman in #29965 * Weak subscription to CanExecuteChange events - fixes #16124 by @sneumaier in #29837 * [iOS, Mac] Fix for downsized image retaining original dimensions in GraphicsView - fixes #30006 by @SyedAbdulAzeemSF4852 in #30007 * [Android] Prevent Picker from Gaining Focus on Touch - fixes #19739, #8546, #13503, #24862, #28121, #21704, #15394 by @bhavanesh2001 in #29068 * Fix CV1 GridItemsLayout centering single item AND Fix Empty view not resizing when bounds change - fixes #29595, #29634 by @albyrock87 in #29639 ### Testing * [Testing] Feature Matrix UITest Cases for Button by @TamilarasanSF4853 in #29803 * [Testing] Feature matrix UITest Cases for BoxView Control by @HarishKumarSF4517 in #29808 * [Testing] Enable HandlerDoesNotLeak for Button and ProgressBar by @bhavanesh2001 in #29896 * [Testing] Add Validation Test For Issue28051 On Android by @prakashKannanSf3972 in #30026 * [Testing] Fixed Test case failure in PR 30115 - [2025/06/23] Candidate by @HarishKumarSF4517 in #30136 ### Dependency Updates * Bump to 1.7.250606001 of WindowsAppSDK by @sneumaier in #29915 ### Housekeeping * [housekeeping] Update namespaces in HostApp and Shared tests projects by @bhavanesh2001 in #29904 * Update SetterSpecificity.cs Remove Extra Line From Bad Merge by @sneumaier in #29987 * Revert - Fixed the Label not sized correctly on Android by @Ahamed-Ali in #30023 * Revert "Fixes Setting BackgroundColor to null does not actually changes BackgroundColor #22914 (#22917)" by @mattleibow in #30031 * [create-pull-request] automated change by @github-actions[bot] in #30019 * [create-pull-request] automated change by @github-actions[bot] in #30043 * [create-pull-request] automated change by @github-actions[bot] in #30078 * Update Controls.TestCases.HostApp.csproj by @HarishKumarSF4517 in #30124 ## New Contributors * @albyrock87 made their first contribution in #29639 * @SyedAbdulAzeemSF4852 made their first contribution in #30007 * @emiller made their first contribution in #20048 * @jgonzalez-gft made their first contribution in #22917 * @aheubusch made their first contribution in #25067 **Full Changelog**: https://github.com/dotnet/maui/compare/main..inflight/candidate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #26863
@rmarinho