[iOS] Fix Shell NavBarIsVisible updates when switching ShellContent by Vignesh-SF3580 · Pull Request #33195 · dotnet/maui

Vignesh-SF3580 · 2025-12-17T08:03:48Z

Issue details

On iOS, Shell.NavBarIsVisible does not update correctly when switching between ShellContent. If the navigation bar is hidden on one page, it can remain hidden on the next page even when it should be visible.

Root cause

NavBar visibility was not updated when the page changed. On Android, it was handled on page changed, but iOS did not handle it.

Description of change

NavBar visibility is now updated whenever the page changes, ensuring the correct visibility state is applied. While addressing this, an additional issue was identified where the navigation bar title briefly showed the previous page’s title when switching ShellContent. This happened because the current page was being set after the navigation animation completed. The fix now sets the current page before the animation starts, ensuring both NavBar visibility and title are updated correctly during ShellContent transitions.

Tested the behavior in the following platforms

Android
Windows
iOS
Mac

Resaving UpdateSearchHandlerMenuItemForTabNavigation test images, since previously the titles (CatsPage and DogsPage) were not centered correctly and the selection indicator was not fully visible. With this fix, both the title alignment and the selection indicator are now updated properly.

Issues Fixed

Fixes #33191

Screenshots

Before Issue Fix	After Issue Fix
33191Before.mov	33191After.mov

Copilot

Pull request overview

This PR fixes a Shell NavBarIsVisible bug on iOS where the navigation bar visibility wouldn't update correctly when switching between ShellContent tabs. Additionally, it resolves an issue where the navigation bar title briefly showed the previous page's title during ShellContent transitions.

Key Changes:

Added NavBar visibility update on page changes
Updated page assignment timing to occur before animation starts instead of after completion

Reviewed changes

Copilot reviewed 4 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ShellItemRenderer.cs	Added UpdateNavBarHidden() call when displayed page changes to ensure NavBar visibility updates correctly
ShellSectionRootRenderer.cs	Moved _tracker.Page assignment to before animation starts (instead of after completion) to fix title display timing
Issue33191.cs (HostApp)	Created test reproduction page with two ShellContent tabs - one with visible NavBar, one hidden
Issue33191.cs (Tests)	Implemented UI test with platform-specific steps for Windows, verifying NavBar updates correctly
*.png (snapshots)	Updated/added test snapshot images for iOS, Mac, Windows, and Android platforms

Copilot · 2025-12-19T12:10:44Z

src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRootRenderer.cs

 					RemoveNonVisibleRenderers();
 				}
+
+				// RemoveNonVisibleRenderers was called after animation completed,which delayed page title updates. 


Missing space after comma in comment. Should be "completed, which" instead of "completed,which".

Suggested change

// RemoveNonVisibleRenderers was called after animation completed,which delayed page title updates.

// RemoveNonVisibleRenderers was called after animation completed, which delayed page title updates.

Copilot · 2025-12-19T12:10:44Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33191.cs

+#if WINDOWS
+        App.TapTab("First Tab");
+        App.WaitForElement("Page 1");
+        App.Tap("Page 1");
+        App.TapTab("First Tab");
+        App.WaitForElement("Page");
+        App.Tap("Page");
+        App.WaitForElement("Page1Label");
+#else
+        App.TapTab("Page 1");
+        App.TapTab("Page");
+        App.WaitForElement("Page1Label");
+#endif


The WINDOWS platform-specific directive should be avoided unless there's a specific technical limitation. According to UI testing guidelines, tests should run on all applicable platforms by default. The test steps for Windows appear to be working around a platform-specific behavior, but this should be documented or the test should be simplified to work consistently across all platforms.

kubaflo

Review Feedback: PR #33195 - [iOS] Fix Shell NavBarIsVisible updates when switching ShellContent

Recommendation

⚠️ Request Changes

Required changes:

Add Shell.NavBarIsVisibleProperty listener to OnDisplayedPagePropertyChanged to handle runtime property changes

Recommended changes:

Consider adding a test case for runtime Shell.NavBarIsVisible changes

📋 Full PR Review Details

Summary

This PR fixes a Shell navigation bar visibility bug on iOS where Shell.NavBarIsVisible was not updated when switching between ShellContent items. The primary fix correctly addresses the reported issue by calling UpdateNavBarHidden() when the displayed page changes. However, testing revealed a gap: runtime changes to Shell.NavBarIsVisible on an already-displayed page do not trigger navbar updates.

Code Review

Primary Fix Analysis (✅ Correct)

ShellItemRenderer.cs - Line 404: Added UpdateNavBarHidden() call in OnDisplayedPageChanged()

Why this works:

When switching between ShellContent tabs, iOS now checks the new page's Shell.NavBarIsVisible setting
This mirrors Android's existing behavior pattern (Android's OnDisplayedPageChanged already handles navbar updates)
The method reads Shell.GetNavBarIsVisible(_displayedPage) and applies it to the UINavigationController
Timing is correct: happens alongside UpdateTabBarHidden() and UpdateLargeTitles()

Root cause identified correctly: iOS was missing navbar visibility updates that Android already had. This is a platform parity fix.

Secondary Fix Analysis (✅ Beneficial)

ShellSectionRootRenderer.cs - Lines 382-387: Moved _tracker.Page = scc.Page to happen BEFORE animation completes

Why this helps:

Previously, the current page was set in RemoveNonVisibleRenderers() which runs AFTER the tab switch animation completes
This caused the navbar title to briefly show the old page's title during the animation
Moving it earlier ensures title and navbar visibility update together during the transition
Side effect: Fixed screenshot test UpdateSearchHandlerMenuItemForTabNavigation (titles now properly centered, selection indicator visible)

This is a legitimate improvement, not a workaround.

Gap Identified (⚠️ Needs Fixing)

ShellItemRenderer.cs - Lines 408-412: OnDisplayedPagePropertyChanged() only listens for Shell.TabBarIsVisibleProperty

void OnDisplayedPagePropertyChanged(object sender, PropertyChangedEventArgs e)
{
    if (e.PropertyName == Shell.TabBarIsVisibleProperty.PropertyName)
        UpdateTabBarHidden();
}

The problem: If code calls Shell.SetNavBarIsVisible(page, false) on a page that's ALREADY displayed, the navbar won't update because there's no listener for Shell.NavBarIsVisibleProperty.PropertyName.

Expected behavior: Runtime changes to Shell.NavBarIsVisible should immediately update the navbar, just like runtime changes to Shell.TabBarIsVisible immediately update the tab bar.

Recommended fix:

void OnDisplayedPagePropertyChanged(object sender, PropertyChangedEventArgs e)
{
    if (e.PropertyName == Shell.TabBarIsVisibleProperty.PropertyName)
        UpdateTabBarHidden();
    if (e.PropertyName == Shell.NavBarIsVisibleProperty.PropertyName)
        UpdateNavBarHidden();
}

Test Coverage

Included Tests (✅ Good)

Test page: Issue33191.cs creates a proper Shell scenario with two ShellContent items

Page 1: Navbar visible (default)
Page 2: Shell.SetNavBarIsVisible(this, false) in constructor

NUnit test: Issue33191.cs validates the scenario

Switches from Page → Page 1 → back to Page
Uses VerifyScreenshot() for visual validation
Cross-platform test (iOS, Android, Windows, Mac with appropriate navigation logic)

Strengths:

Directly tests the reported issue
Simple, focused scenario
Proper use of AutomationIds
Platform-appropriate navigation logic (#if WINDOWS uses different tap sequence)

Test Gap Identified (⚠️ Missing)

Missing scenario: Runtime property changes

The included test only validates navbar visibility during ShellContent navigation (page switches). It doesn't test programmatic changes to Shell.NavBarIsVisible after the page is already displayed.

Why this matters: Users might toggle navbar visibility in response to events (button clicks, scrolling, etc.). The current PR doesn't handle this case due to the missing property change listener.

Suggested test scenario:

// Page with button that toggles Shell.NavBarIsVisible
toggleButton.Clicked += (s, e) => {
    bool current = Shell.GetNavBarIsVisible(this);
    Shell.SetNavBarIsVisible(this, !current);
};

This scenario would fail with the current PR implementation.

Testing Results

Platform: iOS 18.5 (Simulator - iPhone Xs)

Tests Run:

✅ Issue33191.NavBarUpdatesWhenSwitchingShellContent - PASSED
- Basic scenario works correctly
- Navbar visibility updates when switching between tabs
❌ Custom edge case test for runtime changes - FAILED (app crash)
- Created test with button to toggle Shell.NavBarIsVisible at runtime
- App crashed during test execution
- Root cause: No property change handler for NavBarIsVisibleProperty
- This confirms the gap in the implementation

Test execution details:

Build time: ~25 seconds (incremental)
Test time: ~7 seconds per test
Logs captured in: CustomAgentLogsTmp/UITests/

Edge Cases Tested

✅ Validated (Works Correctly)

Tab switching with mixed navbar visibility: Page with navbar → Page without navbar → Back to page with navbar
Cross-platform consistency: Test runs on iOS, Android, Windows, MacCatalyst
Title update timing: Secondary fix ensures titles update smoothly during navigation

❌ Identified Issues

Runtime property changes: Programmatic calls to Shell.SetNavBarIsVisible() on displayed pages don't work
Rapid tab switching: Not explicitly tested, but likely safe since the fix runs synchronously during page change
Property changes during animation: Not tested, but the secondary fix (updating before animation) should mitigate issues

⏸️ Not Tested (Out of Scope)

Modal navigation with navbar visibility changes
Deep linking + navbar visibility restoration
Memory leak verification (property changed handler subscription/unsubscription looks correct)

Issues Found

Must Fix

Issue #1: Runtime property changes don't trigger navbar updates

Severity: Medium - Breaks valid use case

Current behavior:

// This does NOT update the navbar on iOS
Shell.SetNavBarIsVisible(currentPage, false);

Root cause: OnDisplayedPagePropertyChanged() doesn't listen for Shell.NavBarIsVisibleProperty.PropertyName

Fix: Add the missing property change handler:

void OnDisplayedPagePropertyChanged(object sender, PropertyChangedEventArgs e)
{
    if (e.PropertyName == Shell.TabBarIsVisibleProperty.PropertyName)
        UpdateTabBarHidden();
    if (e.PropertyName == Shell.NavBarIsVisibleProperty.PropertyName)
        UpdateNavBarHidden();
}

Impact: Low risk - This is a simple addition following the existing pattern for TabBarIsVisible

Should Fix

Issue #2: Missing test coverage for runtime property changes

Severity: Low - Test coverage gap

Recommendation: Add a test case that validates runtime toggling of Shell.NavBarIsVisible works correctly. This would catch the issue identified above and prevent future regressions.

Example test scenario:

Page with button
Button click toggles Shell.SetNavBarIsVisible(this, !current)
Test verifies navbar appears/disappears on each click

Platform Considerations

Why Android Doesn't Need This Fix

Android's ShellItemRenderer.OnDisplayedPageChanged() doesn't call a navbar update method because Android handles navbar visibility differently:

Android doesn't have a persistent navigation bar in the same way iOS does
Android's action bar visibility is typically managed through the Activity, not per-page
The architecture difference is acceptable

iOS-Specific Implementation Details

The iOS fix correctly uses:

navigationController.SetNavigationBarHidden(
    !Shell.GetNavBarIsVisible(_displayedPage), 
    Shell.GetNavBarVisibilityAnimationEnabled(_displayedPage)
);

This respects both the visibility setting AND the animation preference, which is the right approach.

Code Quality Assessment

Strengths

✅ Minimal, surgical change
✅ Follows existing patterns (matches how UpdateTabBarHidden() is called)
✅ Proper null checking
✅ Includes comprehensive test with cross-platform support
✅ Secondary fix improves user experience (smooth title transitions)
✅ Screenshot test updates are justified side effects

Weaknesses

⚠️ Missing property change handler for runtime updates
⚠️ No test coverage for runtime property changes
ℹ️ Minor: Comment in ShellSectionRootRenderer has typo ("completed,which" should be "completed, which")

Security & Performance

Security: ✅ No concerns

No user input handling
No external resources
No sensitive data exposure

Performance: ✅ No concerns

Method calls are lightweight
No allocations or expensive operations
Synchronous execution is appropriate for UI updates

Approval Checklist

Code solves the stated problem (for tab switching)
Minimal, focused changes
Appropriate test coverage (missing runtime property change test)
No security concerns
Follows .NET MAUI conventions
Handles all edge cases (runtime property changes not handled)

Review Metadata

Reviewer: PR Review Agent
Date: 2025-12-25
PR: #33195
Issue: #33191
Platforms Tested: iOS 18.5
Branch: pr-33195 (fix-navBarVisible)
Commits: 7 commits, 121 additions, 2 deletions

Summary for PR Author

Your fix correctly addresses the reported issue (navbar visibility during ShellContent navigation). However, there's a gap: runtime changes to Shell.NavBarIsVisible on already-displayed pages won't work because the property change handler is missing.

Quick fix: Add one line to OnDisplayedPagePropertyChanged():

if (e.PropertyName == Shell.NavBarIsVisibleProperty.PropertyName)
    UpdateNavBarHidden();

This follows the exact pattern already used for TabBarIsVisible and will ensure runtime property changes work correctly.

Great work identifying and fixing the core issue! This is a solid PR that just needs one small addition to be complete.

kubaflo · 2025-12-25T23:49:50Z

https://github.com/user-attachments/files/24341135/chat.json

PureWeen

Thoughts?

#33195 (review)

@kubaflo thoughts?

Response to @kubaflo's Review on PR #33195

The "Request Changes" is based on an incorrect assumption. Runtime Shell.SetNavBarIsVisible() changes are already handled - just not where the reviewer looked.

The Key Finding

ShellSectionRenderer (line 590-593) already listens for NavBarIsVisibleProperty changes:

void OnDisplayedPagePropertyChanged(object sender, PropertyChangedEventArgs e)
{
    if (e.PropertyName == Shell.NavBarIsVisibleProperty.PropertyName)
        UpdateNavigationBarHidden();
}

Test Validation

I created and ran a runtime toggle test on iOS 18.5:

Test	Result
Tap button → NavBar hides	✅ Passed
Tap button again → NavBar shows	✅ Passed
App crash	❌ Did NOT crash

Why the Suggested Change is Unnecessary

Component	Handles `NavBarIsVisibleProperty`?	Owns NavBar?
`ShellItemRenderer` (UITabBarController)	❌ No	❌ No
`ShellSectionRenderer` (UINavigationController)	✅ Yes	✅ Yes

Adding the handler to ShellItemRenderer would create redundant duplicate handling.

Recommendation

PR is correct as-is. The "gap" identified in the review doesn't exist - it's handled by a different renderer that owns the actual NavBar.

kubaflo · 2025-12-26T23:42:51Z

@PureWeen yes it makes sense. ShellItemRenderer inherits from UITabBarController while ShellSectionRenderer from UINavigationController, so my session was wrong

kubaflo · 2025-12-26T23:59:46Z

@PureWeen what do you think?
Improvements based on lessons learned from this PR: #33302

PureWeen · 2025-12-27T15:52:42Z

@kubaflo is this one good to merge?

kubaflo · 2025-12-27T16:37:10Z

@PureWeen yes

…33195) ### Issue details On iOS, Shell.NavBarIsVisible does not update correctly when switching between ShellContent. If the navigation bar is hidden on one page, it can remain hidden on the next page even when it should be visible. ### Root cause NavBar visibility was not updated when the page changed. On Android, it was handled on page changed, but iOS did not handle it. ### Description of change NavBar visibility is now updated whenever the page changes, ensuring the correct visibility state is applied. While addressing this, an additional issue was identified where the navigation bar title briefly showed the previous page’s title when switching ShellContent. This happened because the current page was being set after the navigation animation completed. The fix now sets the current page before the animation starts, ensuring both NavBar visibility and title are updated correctly during ShellContent transitions. ### Tested the behavior in the following platforms - [x] Android - [x] Windows - [x] iOS - [x] Mac Resaving UpdateSearchHandlerMenuItemForTabNavigation test images, since previously the titles (CatsPage and DogsPage) were not centered correctly and the selection indicator was not fully visible. With this fix, both the title alignment and the selection indicator are now updated properly. ### Issues Fixed Fixes #33191 ### Screenshots | Before Issue Fix | After Issue Fix | |----------|----------| | <video width="300" height="600" src="https://github.com/user-attachments/assets/d41fadf2-2cb1-4f16-8cda-ae284078d0c6"> | <video width="300" height="600" src="https://github.com/user-attachments/assets/8898360a-8f73-4739-a945-9997aae3f53c">) |

@devanathan-vaithiyanathan

## What's Coming .NET MAUI inflight/candidate introduces significant improvements across all platforms with focus on quality, performance, and developer experience. This release includes 27 commits with various improvements, bug fixes, and enhancements. ## CollectionView - [iOS][CV2] Fix page can be dragged down, and it would cause an extra space between Header and EmptyView text by @devanathan-vaithiyanathan in #31840 <details> <summary>🔧 Fixes</summary> - [I8_Header_and_Footer_Null - The page can be dragged down, and it would cause an extra space between Header and EmptyView text.](#31465) </details> - [iOS] Fixed the Items not displayed properly in CarouselView2 by @Ahamed-Ali in #31336 <details> <summary>🔧 Fixes</summary> - [[iOS] Items are not updated properly in CarouselView2.](#31148) </details> ## Docs - Improve Controls Core API docs by @jfversluis in #33240 ## Editor - [iOS] Fixed an issue where an Editor with a small height inside a ScrollView would cause the entire page to scroll by @Tamilarasan-Paranthaman in #27948 <details> <summary>🔧 Fixes</summary> - [[iOS][Editor] An Editor that has not enough height and resides inside a ScrollView/CollectionView will scroll the entire page](#27750) </details> ## Image - [Android] Image control crashes on Android when image width exceeds height by @KarthikRajaKalaimani in #33045 <details> <summary>🔧 Fixes</summary> - [Image control crashes on Android when image width exceeds height](#32869) </details> ## Mediapicker - [Android 🤖] Add a log telling why the request is cancelled by @pictos in #33295 <details> <summary>🔧 Fixes</summary> - [MediaPicker.PickPhotosAsync throwing TaskCancelledException in net10-android](#33283) </details> ## Navigation - [Android] Fix for App Hang When PopModalAsync Is Called Immediately After PushModalAsync with Task.Yield() by @BagavathiPerumal in #32479 <details> <summary>🔧 Fixes</summary> - [App hangs if PopModalAsync is called after PushModalAsync with single await Task.Yield()](#32310) </details> - [iOS 26] Navigation hangs after rapidly open and closing new page using Navigation.PushAsync - fix by @kubaflo in #32456 <details> <summary>🔧 Fixes</summary> - [[iOS 26] Navigation hangs after rapidly open and closing new page using Navigation.PushAsync](#32425) </details> ## Pages - [iOS] Fix ContentPage BackgroundImageSource not working by @Shalini-Ashokan in #33297 <details> <summary>🔧 Fixes</summary> - [.Net MAUI- Page.BackgroundImageSource not working for iOS](#21594) </details> ## RadioButton - [Issue-Resolver] Fix #33264 - RadioButtonGroup not working with Collection View by @kubaflo in #33343 <details> <summary>🔧 Fixes</summary> - [RadioButtonGroup not working with CollectionView](#33264) </details> ## SafeArea - [Android] Fixed Label Overlapped by Android Status Bar When Using SafeAreaEdges="Container" in .NET MAUI by @NirmalKumarYuvaraj in #33285 <details> <summary>🔧 Fixes</summary> - [SafeAreaEdges works correctly only on the first tab in Shell. Other tabs have content colliding with the display cutout in the landscape mode.](#33034) - [Label Overlapped by Android Status Bar When Using SafeAreaEdges="Container" in .NET MAUI](#32941) - [[MAUI 10] Layout breaks on first navigation (Shell // route) until soft keyboard appears/disappears (Android + iOS)](#33038) </details> ## ScrollView - [Windows, Android] Fix ScrollView Content Not Removed When Set to Null by @devanathan-vaithiyanathan in #33069 <details> <summary>🔧 Fixes</summary> - [[Windows, Android] ScrollView Content Not Removed When Set to Null](#33067) </details> ## Searchbar - Fix Android crash when changing shared Drawable tint on Searchbar by @tritter in #33071 <details> <summary>🔧 Fixes</summary> - [[Android] Crash on changing Tint of Searchbar](#33070) </details> ## Shell - [iOS] - Fix Custom FlyoutIcon from Being Overridden to Default Color in Shell by @prakashKannanSf3972 in #27580 <details> <summary>🔧 Fixes</summary> - [Change the flyout icon color](#6738) </details> - [iOS] Fix Shell NavBarIsVisible updates when switching ShellContent by @Vignesh-SF3580 in #33195 <details> <summary>🔧 Fixes</summary> - [[iOS] Shell NavBarIsVisible is not updated when changing ShellContent](#33191) </details> ## Slider - [C] Fix Slider and Stepper property order independence by @StephaneDelcroix in #32939 <details> <summary>🔧 Fixes</summary> - [Slider Binding Initialization Order Causes Incorrect Value Assignment in XAML](#32903) - [Slider is very broken, Value is a mess when setting Minimum](#14472) - [Slider is buggy depending on order of properties](#18910) - [Stepper Value is incorrectly clamped to default min/max when using bindableproperties in MVVM pattern](#12243) - [[Issue-Resolver] Fix #32903 - Sliderbinding initialization order issue](#32907) </details> ## Stepper - [Windows] Maui Stepper: Clamp minimum and maximum value by @OomJan in #33275 <details> <summary>🔧 Fixes</summary> - [[Windows] Maui Stepper is not clamped to minimum or maximum internally](#33274) </details> - [iOS] Fixed the UIStepper Value from being clamped based on old higher MinimumValue - Candidate PR test failure fix- 33363 by @Ahamed-Ali in #33392 ## TabbedPage - [windows] Fixed Rapid change of selected tab results in crash. by @praveenkumarkarunanithi in #33113 <details> <summary>🔧 Fixes</summary> - [Rapid change of selected tab results in crash on Windows.](#32824) </details> ## Titlebar - [Mac] Fix TitleBar Content Overlapping with Traffic Light Buttons on Latest macOS Version by @devanathan-vaithiyanathan in #33157 <details> <summary>🔧 Fixes</summary> - [TitleBar Content Overlapping with Traffic Light Buttons on Latest macOS Version](#33136) </details> ## Xaml - Fix for Control does not update from binding anymore after MultiBinding.ConvertBack is called by @BagavathiPerumal in #33128 <details> <summary>🔧 Fixes</summary> - [Control does not update from binding anymore after MultiBinding.ConvertBack is called](#24969) - [The issue with the MultiBinding converter with two way binding mode does not work properly when changing the values.](#20382) </details> <details> <summary>🔧 Infrastructure (1)</summary> - Avoid KVO on CALayer by introducing an Apple PlatformInterop by @albyrock87 in #30861 </details> <details> <summary>🧪 Testing (2)</summary> - [Testing] Enable UITest Issue18193 on MacCatalyst by @NafeelaNazhir in #31653 <details> <summary>🔧 Fixes</summary> - [Test Issue18193 was disabled on Mac Catalyst](#27206) </details> - Set the CV2 handlers as the default by @Ahamed-Ali in #33177 </details> <details> <summary>📦 Other (3)</summary> - Update WindowsAppSDK to 1.8 by @mattleibow in #32174 <details> <summary>🔧 Fixes</summary> - [Update to WindowsAppSDK](#30858) </details> - Fix command dependency reentrancy by @simonrozsival in #33129 - Fix SafeArea AdjustPan handling and add AdjustNothing mode tests by @PureWeen via @Copilot in #33354 </details> **Full Changelog**: main...inflight/candidate

…otnet#33195) ### Issue details On iOS, Shell.NavBarIsVisible does not update correctly when switching between ShellContent. If the navigation bar is hidden on one page, it can remain hidden on the next page even when it should be visible. ### Root cause NavBar visibility was not updated when the page changed. On Android, it was handled on page changed, but iOS did not handle it. ### Description of change NavBar visibility is now updated whenever the page changes, ensuring the correct visibility state is applied. While addressing this, an additional issue was identified where the navigation bar title briefly showed the previous page’s title when switching ShellContent. This happened because the current page was being set after the navigation animation completed. The fix now sets the current page before the animation starts, ensuring both NavBar visibility and title are updated correctly during ShellContent transitions. ### Tested the behavior in the following platforms - [x] Android - [x] Windows - [x] iOS - [x] Mac Resaving UpdateSearchHandlerMenuItemForTabNavigation test images, since previously the titles (CatsPage and DogsPage) were not centered correctly and the selection indicator was not fully visible. With this fix, both the title alignment and the selection indicator are now updated properly. ### Issues Fixed Fixes dotnet#33191 ### Screenshots | Before Issue Fix | After Issue Fix | |----------|----------| | <video width="300" height="600" src="https://github.com/user-attachments/assets/d41fadf2-2cb1-4f16-8cda-ae284078d0c6"> | <video width="300" height="600" src="https://github.com/user-attachments/assets/8898360a-8f73-4739-a945-9997aae3f53c">) |

Vignesh-SF3580 added 6 commits December 11, 2025 19:31

Update ShellItemRenderer.cs

bb5f6b5

Update ShellSectionRootRenderer.cs

c7fa562

Update ShellSectionRootRenderer.cs

9e77edd

added testcase

ef71354

updated test.

18e5046

added snapshots.

628e54e

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 17, 2025

Vignesh-SF3580 added the community ✨ Community Contribution label Dec 17, 2025

Tamilarasan-Paranthaman added platform/ios area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Dec 17, 2025

build-analysis bot mentioned this pull request Dec 17, 2025

"We stopped hearing from agent Azure Pipelines 32. Verify the agent machine is running and has a healthy network connection" dotnet/dnceng#1886

Open

3 tasks

added pending snap and resolve test failure.

ba51c5c

sheiksyedm marked this pull request as ready for review December 19, 2025 12:00

Copilot AI review requested due to automatic review settings December 19, 2025 12:00

Copilot started reviewing on behalf of sheiksyedm December 19, 2025 12:01 View session

Copilot AI reviewed Dec 19, 2025

View reviewed changes

kubaflo requested changes Dec 25, 2025

View reviewed changes

PureWeen reviewed Dec 26, 2025

View reviewed changes

kubaflo self-requested a review December 26, 2025 23:44

kubaflo approved these changes Dec 27, 2025

View reviewed changes

PureWeen added this to the .NET 10.0 SR3 milestone Dec 28, 2025

PureWeen added this to MAUI SDK Ongoing Dec 28, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing Dec 28, 2025

PureWeen approved these changes Dec 30, 2025

View reviewed changes

github-project-automation bot moved this from Todo to Approved in MAUI SDK Ongoing Dec 30, 2025

PureWeen changed the base branch from main to inflight/current December 30, 2025 15:43

PureWeen merged commit 20220c0 into dotnet:inflight/current Dec 30, 2025
163 of 167 checks passed

github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Dec 30, 2025

PureWeen mentioned this pull request Jan 7, 2026

January 5th, Candidate #33363

Merged

github-actions bot locked and limited conversation to collaborators Jan 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iOS] Fix Shell NavBarIsVisible updates when switching ShellContent#33195

[iOS] Fix Shell NavBarIsVisible updates when switching ShellContent#33195
PureWeen merged 7 commits intodotnet:inflight/currentfrom
Vignesh-SF3580:fix-navBarVisible

Vignesh-SF3580 commented Dec 17, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 19, 2025

Uh oh!

Copilot AI Dec 19, 2025

Uh oh!

kubaflo left a comment

Uh oh!

kubaflo commented Dec 25, 2025

Uh oh!

PureWeen left a comment •

edited

Loading

Uh oh!

kubaflo commented Dec 26, 2025

Uh oh!

kubaflo commented Dec 26, 2025

Uh oh!

PureWeen commented Dec 27, 2025

Uh oh!

kubaflo commented Dec 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	// RemoveNonVisibleRenderers was called after animation completed,which delayed page title updates.
	// RemoveNonVisibleRenderers was called after animation completed, which delayed page title updates.

Conversation

Vignesh-SF3580 commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue details

Root cause

Description of change

Tested the behavior in the following platforms

Issues Fixed

Screenshots

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

kubaflo left a comment

Choose a reason for hiding this comment

Review Feedback: PR #33195 - [iOS] Fix Shell NavBarIsVisible updates when switching ShellContent

Recommendation

Summary

Code Review

Primary Fix Analysis (✅ Correct)

Secondary Fix Analysis (✅ Beneficial)

Gap Identified (⚠️ Needs Fixing)

Test Coverage

Included Tests (✅ Good)

Test Gap Identified (⚠️ Missing)

Testing Results

Edge Cases Tested

✅ Validated (Works Correctly)

❌ Identified Issues

⏸️ Not Tested (Out of Scope)

Issues Found

Must Fix

Should Fix

Platform Considerations

Why Android Doesn't Need This Fix

iOS-Specific Implementation Details

Code Quality Assessment

Strengths

Weaknesses

Security & Performance

Approval Checklist

Review Metadata

Summary for PR Author

Uh oh!

kubaflo commented Dec 25, 2025

Uh oh!

PureWeen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Response to @kubaflo's Review on PR #33195

The Key Finding

Test Validation

Why the Suggested Change is Unnecessary

Recommendation

Uh oh!

kubaflo commented Dec 26, 2025

Uh oh!

kubaflo commented Dec 26, 2025

Uh oh!

PureWeen commented Dec 27, 2025

Uh oh!

kubaflo commented Dec 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Vignesh-SF3580 commented Dec 17, 2025 •

edited

Loading

PureWeen left a comment •

edited

Loading