Implement JsonStringEnumConverter<TEnum>#87224
Merged
eiriktsarpalis merged 12 commits intodotnet:mainfrom Jun 7, 2023
Merged
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
663b350 to
3154988
Compare
eiriktsarpalis
commented
Jun 7, 2023
eerhardt
reviewed
Jun 7, 2023
eerhardt
approved these changes
Jun 7, 2023
Member
eerhardt
left a comment
There was a problem hiding this comment.
Thanks for the great work here @eiriktsarpalis!
…assed invalid inputs.
This was referenced Jun 8, 2023
eerhardt
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Jun 8, 2023
…rce generator warning. InteractionType is used in a JsonSerializerContext. With dotnet/runtime#87224, there is now a warning to convert source generated usages of JsonStringEnumConverter to JsonStringEnumConverter<TEnum>. I went ahead and updated the other 2 usages as well, to make them consistent.
dotnet-maestro bot
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Jun 8, 2023
[main] Update dependencies from dotnet/efcore dotnet/runtime - Fix Http Results test to respond to dotnet/runtime#87093 - Convert to new generic JsonStringEnumConverter<TEnum> to fix JSON source generator warning. InteractionType is used in a JsonSerializerContext. With dotnet/runtime#87224, there is now a warning to convert source generated usages of JsonStringEnumConverter to JsonStringEnumConverter<TEnum>. I went ahead and updated the other 2 usages as well, to make them consistent. - Skip AcceptAsync_NoCertificateCallback_RemovedFromPendingConnections See #48678
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #87149. Fixes #79311.