Standardize README prerequisites across all SDK languages#1636
Conversation
Move the .NET README requirements section above installation, rename it to prerequisites, and clarify the runtime requirement as any .NET Standard 2.0-compatible implementation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Reorganizes the .NET SDK README to surface runtime requirements up front and clarifies framework compatibility so users don’t incorrectly infer that .NET 8 is required for all use cases.
Changes:
- Adds a new Prerequisites section before Installation.
- Updates wording to state support for any .NET Standard 2.0-compatible implementation and links to Microsoft Learn guidance.
- Removes the older “Requirements” section previously located near the bottom of the README.
Show a summary per file
| File | Description |
|---|---|
| dotnet/README.md | Moves requirements into a Prerequisites section and clarifies .NET Standard 2.0 compatibility with an external reference link. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This comment has been minimized.
This comment has been minimized.
|
@copilot Update this PR to also address the suggestion in #1636 (comment) |
Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
Done. Applied the consistent
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Generated by SDK Consistency Review Agent for issue #1636 · sonnet46 871.4K
|
@copilot update this PR to address the suggestions in #1636 (comment) |
Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
Done. Updated |
This comment has been minimized.
This comment has been minimized.
|
@copilot update this PR to address the pre-existing nit mentioned in #1636 (comment) |
Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
Fixed in the latest commit — removed the stray trailing period from |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stephentoub
left a comment
There was a problem hiding this comment.
Other than the .NET issue, LGTM
…SDK READMEs Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
…READMEs Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
Cross-SDK consistency review ✅This PR achieves strong cross-SDK documentation consistency. Here's my review: What's consistent across all six SDKs
CLI bundling treatment (correctly differentiated)
On the open thread re: Java CLI bundlingI checked One minor inconsistency worth considering
Since both SDKs require the CLI installed by the user, it may be worth either adding a minimum version to the Go prerequisite or removing the version from Java for consistency. That said, this is a minor point and may be intentional if Go has broader version compatibility. Overall, the PR is well-structured and the cross-SDK consistency is in good shape.
|
SDK READMEs lacked consistent structure and placement for prerequisites. Several SDKs also incorrectly listed the GitHub Copilot CLI as a prerequisite despite bundling it.
Changes
"To use the SDK, you'll need:"lead-in sentence before the prerequisites bullet list indotnet,nodejs,python,go,rust, andjavaREADMEs## Requirements→## Prerequisites; move before## Installation### Runtime requirements(nested under Installation) to a top-level## Prerequisitessection## Prerequisitessections before Installation / Quick Start