Skip to content

Standardize README prerequisites across all SDK languages#1636

Merged
stephentoub merged 9 commits into
mainfrom
scottaddie/readme-prerequisites
Jun 16, 2026
Merged

Standardize README prerequisites across all SDK languages#1636
stephentoub merged 9 commits into
mainfrom
scottaddie/readme-prerequisites

Conversation

@scottaddie

@scottaddie scottaddie commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

SDK READMEs lacked consistent structure and placement for prerequisites. Several SDKs also incorrectly listed the GitHub Copilot CLI as a prerequisite despite bundling it.

Changes

  • All SDKs: Add "To use the SDK, you'll need:" lead-in sentence before the prerequisites bullet list in dotnet, nodejs, python, go, rust, and java READMEs
  • .NET / Node.js / Python / Rust: Remove the CLI installation bullet from Prerequisites — these SDKs bundle the CLI, so it is not a consumer requirement
  • .NET: Move Prerequisites above Installation; clarify any .NET Standard 2.0-compatible implementation is supported (not just .NET 8)
  • Node.js / Python: Rename ## Requirements## Prerequisites; move before ## Installation
  • Java: Promote ### Runtime requirements (nested under Installation) to a top-level ## Prerequisites section
  • Go / Rust: Add new ## Prerequisites sections before Installation / Quick Start

Move the .NET README requirements section above installation, rename it to prerequisites, and clarify the runtime requirement as any .NET Standard 2.0-compatible implementation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 11, 2026 21:50
@scottaddie scottaddie requested a review from a team as a code owner June 11, 2026 21:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reorganizes the .NET SDK README to surface runtime requirements up front and clarifies framework compatibility so users don’t incorrectly infer that .NET 8 is required for all use cases.

Changes:

  • Adds a new Prerequisites section before Installation.
  • Updates wording to state support for any .NET Standard 2.0-compatible implementation and links to Microsoft Learn guidance.
  • Removes the older “Requirements” section previously located near the bottom of the README.
Show a summary per file
File Description
dotnet/README.md Moves requirements into a Prerequisites section and clarifies .NET Standard 2.0 compatibility with an external reference link.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions

This comment has been minimized.

@scottaddie scottaddie marked this pull request as draft June 11, 2026 21:58
@scottaddie

Copy link
Copy Markdown
Contributor Author

@copilot Update this PR to also address the suggestion in #1636 (comment)

Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>

Copilot AI commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@copilot Update this PR to also address the suggestion in #1636 (comment)

Done. Applied the consistent ## Prerequisites pattern across all SDK READMEs in commit Apply consistent Prerequisites sections across all SDK READMEs:

  • Node.js: renamed ## Requirements## Prerequisites, moved before ## Installation
  • Python: same as Node.js
  • Java: promoted the ### Runtime requirements subsection (inside Installation) to a top-level ## Prerequisites section placed before Installation
  • Go: added a new ## Prerequisites section before ## Installation listing Go 1.24+ and CLI requirements
  • Rust: added a new ## Prerequisites section before ## Quick Start listing Rust 1.94.0+ and noting the bundled-cli default

Copilot AI changed the title Clarify .NET README prerequisites Standardize README prerequisites across all SDK languages Jun 11, 2026
@scottaddie scottaddie marked this pull request as ready for review June 11, 2026 22:06
@github-actions

This comment has been minimized.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated by SDK Consistency Review Agent for issue #1636 · sonnet46 871.4K

Comment thread python/README.md Outdated
@scottaddie

Copy link
Copy Markdown
Contributor Author

@copilot update this PR to address the suggestions in #1636 (comment)

Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>

Copilot AI commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@copilot update this PR to address the suggestions in #1636 (comment)

Done. Updated python/README.md to change "GitHub Copilot CLI installed and accessible" to "GitHub Copilot CLI installed and in PATH (or provide a custom connection=RuntimeConnection.for_stdio(path=...))". This now matches the specificity pattern used by all other SDK READMEs.

@github-actions

This comment has been minimized.

@scottaddie

Copy link
Copy Markdown
Contributor Author

@copilot update this PR to address the pre-existing nit mentioned in #1636 (comment)

Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>

Copilot AI commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@copilot update this PR to address the pre-existing nit mentioned in #1636 (comment)

Fixed in the latest commit — removed the stray trailing period from 1.0.55-5.1.0.55-5 in java/README.md.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Comment thread dotnet/README.md

@stephentoub stephentoub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the .NET issue, LGTM

Comment thread dotnet/README.md Outdated
…SDK READMEs

Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
Comment thread dotnet/README.md Outdated
…READMEs

Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>

@edburns edburns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Java

@scottaddie scottaddie requested a review from stephentoub June 15, 2026 17:10
Comment thread java/README.md
Comment thread nodejs/README.md Outdated
Comment thread python/README.md Outdated
Comment thread rust/README.md Outdated
@github-actions

This comment has been minimized.

Co-authored-by: scottaddie <10702007+scottaddie@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Cross-SDK consistency review ✅

This PR achieves strong cross-SDK documentation consistency. Here's my review:

What's consistent across all six SDKs

Property All SDKs
Section heading ## Prerequisites
Lead-in sentence "To use the SDK, you'll need:" ✓
Section placement Before Installation / Quick Start ✓
Language runtime listed

CLI bundling treatment (correctly differentiated)

SDK Bundles CLI? CLI listed as prereq? Correct?
.NET Yes (downloads at build via MSBuild targets) No
Node.js Yes (npm package) No
Python Yes (platform wheels) No
Rust Yes (bundled-cli feature, on by default) No
Go Opt-in only (go tool bundler) Yes
Java No Yes

On the open thread re: Java CLI bundling

I checked java/src/main/java/com/github/copilot/CliServerManager.java — Java defaults to "copilot" in PATH and has no download or embed mechanism. It does not bundle the CLI, unlike .NET/Node.js/Python/Rust. The PR correctly lists it as a Java prerequisite. Java also does not support the COPILOT_CLI_PATH environment variable (unlike Go), only the cliPath option in CopilotClientOptions.

One minor inconsistency worth considering

  • Java specifies a minimum CLI version: GitHub Copilot CLI 1.0.55-5 or later
  • Go does not: GitHub Copilot CLI installed and in \PATH``

Since both SDKs require the CLI installed by the user, it may be worth either adding a minimum version to the Go prerequisite or removing the version from Java for consistency. That said, this is a minor point and may be intentional if Go has broader version compatibility.

Overall, the PR is well-structured and the cross-SDK consistency is in good shape.

Generated by SDK Consistency Review Agent for issue #1636 · sonnet46 1.3M ·

@stephentoub stephentoub added this pull request to the merge queue Jun 16, 2026
Merged via the queue into main with commit 8ae873d Jun 16, 2026
15 checks passed
@stephentoub stephentoub deleted the scottaddie/readme-prerequisites branch June 16, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants