Skip to content

Updates to CONTRIBUTING.md - #406

Merged
jspellman814 merged 10 commits into
developfrom
contrib-md
May 2, 2023
Merged

Updates to CONTRIBUTING.md#406
jspellman814 merged 10 commits into
developfrom
contrib-md

Conversation

@jspellman814

Copy link
Copy Markdown

No description provided.

@jspellman814
jspellman814 requested a review from a team as a code owner May 1, 2023 21:05
@jspellman814
jspellman814 requested a review from a team May 1, 2023 21:05
Comment thread README.md
pwtyler
pwtyler previously approved these changes May 1, 2023

@pwtyler pwtyler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got confused by how master and develop had diverged and thought there were a lot more changes outstanding. Will need to address that separately once we get to cutting a release.

@jspellman814
jspellman814 requested a review from pwtyler May 2, 2023 15:32
pwtyler
pwtyler previously approved these changes May 2, 2023

@pwtyler pwtyler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to see distinct circle steps here otherwise lgtm

Comment thread .circleci/config.yml Outdated
Comment thread .circleci/config.yml Outdated
Co-authored-by: Phil Tyler <philip@tylerdigital.com>
Co-authored-by: Phil Tyler <philip@tylerdigital.com>
@jspellman814
jspellman814 merged commit 943490c into develop May 2, 2023
@jspellman814
jspellman814 deleted the contrib-md branch May 2, 2023 17:58
jspellman814 pushed a commit that referenced this pull request May 8, 2023
jspellman814 pushed a commit that referenced this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants