[vec128] Fix fmsub NEON defintion - #152075
Closed
malfet wants to merge 2 commits into
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152075
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 43 PendingAs of commit e61b271 with merge base 2f74cff ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
added a commit
that referenced
this pull request
Apr 24, 2025
As reported in #149292 According to manual, `vfmsq_f32` implements `c - a * b` rather than `a * b - c`, so it's call must be prefixed with `vnegq_f32` Also, adjust the tests to use OpMath for FMA computation to avoid accuracy error accumulation due to non-fused multiply-and-add over lower precision dtypes Run `./bin/vec_test_all_types_DEFAULT` during MacOS testing Fixes #149292 ghstack-source-id: 2b49ca2 Pull Request resolved: #152075
malfet
added a commit
that referenced
this pull request
Apr 24, 2025
As reported in #149292 According to manual, `vfmsq_f32` implements `c - a * b` rather than `a * b - c`, so it's call must be prefixed with `vnegq_f32` Also, adjust the tests to use OpMath for FMA computation to avoid accuracy error accumulation due to non-fused multiply-and-add over lower precision dtypes Run `./bin/vec_test_all_types_DEFAULT` during MacOS testing Fixes #149292 ghstack-source-id: 58b498b Pull Request resolved: #152075
Collaborator
Author
|
@pytorchbot merge -f "This seems fine" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
|
@pytorchbot cherry-pick --onto release/2.7 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
May 7, 2025
As reported in #149292, according to manual, `vfmsq_f32` implements `c - a * b` rather than `a * b - c`, so it's call must be prefixed with `vnegq_f32` Also, adjust the tests to use OpMath for FMA computation to avoid accuracy error accumulation due to non-fused multiply-and-add over lower precision dtypes Note that `Vectorized::fmsub` is not currently instantiated anywhere, so it could safely remain broken TODO: - Enable C++ testing on MacOS and/or aarch64 platforms (right now Mac tests are build without C++ tests) Fixes #149292 Pull Request resolved: #152075 Approved by: https://github.com/swolchok ghstack dependencies: #151955 (cherry picked from commit 2ea8653)
Collaborator
Cherry picking #152075The cherry pick PR is at #153093 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
atalman
pushed a commit
that referenced
this pull request
May 7, 2025
[vec128] Fix fmsub NEON defintion (#152075) As reported in #149292, according to manual, `vfmsq_f32` implements `c - a * b` rather than `a * b - c`, so it's call must be prefixed with `vnegq_f32` Also, adjust the tests to use OpMath for FMA computation to avoid accuracy error accumulation due to non-fused multiply-and-add over lower precision dtypes Note that `Vectorized::fmsub` is not currently instantiated anywhere, so it could safely remain broken TODO: - Enable C++ testing on MacOS and/or aarch64 platforms (right now Mac tests are build without C++ tests) Fixes #149292 Pull Request resolved: #152075 Approved by: https://github.com/swolchok ghstack dependencies: #151955 (cherry picked from commit 2ea8653) Co-authored-by: Nikita Shulga <nshulga@meta.com>
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As reported in #149292, according to manual,
vfmsq_f32implementsc - a * brather thana * b - c, so it's call must be prefixed withvnegq_f32Also, adjust the tests to use OpMath for FMA computation to avoid accuracy error accumulation due to non-fused multiply-and-add over lower precision dtypes
Note that
Vectorized::fmsubis not currently instantiated anywhere, so it could safely remain brokenTODO:
Fixes #149292
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168