Don't lint T and F if followed by [#2947
Merged
MichaelChirico merged 4 commits intor-lib:mainfrom Oct 16, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2947 +/- ##
=======================================
Coverage 99.24% 99.24%
=======================================
Files 129 129
Lines 7276 7276
=======================================
Hits 7221 7221
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Don't forget to cite yourself in the NEWS :) |
| expect_lint("DF$bool <- T", msg_true, linter) | ||
| expect_lint("S4@bool <- T", msg_true, linter) | ||
| expect_lint("sum(x, na.rm = T)", msg_true, linter) | ||
| expect_lint("x[T]", msg_true, linter) |
Collaborator
There was a problem hiding this comment.
Great test. Indeed using T (as TRUE) to index a vector is valid, and we'd be better off linting it as here.
MichaelChirico
approved these changes
Oct 16, 2025
TimTaylor
pushed a commit
to TimTaylor/lintr
that referenced
this pull request
Oct 29, 2025
* Don't lint T and F if followed by `[`. * Address review comments. * subsume into same expr[] as $ and @ --------- Co-authored-by: Michael Chirico <chiricom@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2944.