limit the allowed roles on img elements - #212
Merged
Merged
Conversation
closes #166 this PR does the following: * limits the allowed roles on an `img` with `alt=some_text`. * limits the disallows roles, or limits the allowed roles on an `img` without an `alt` attribute based on whether it is provided an accessible name via other means.
Member
|
I believe |
Member
Author
|
@rdeltour, PRs welcome :) |
scottaohara
added a commit
to scottaohara/validator
that referenced
this pull request
Dec 3, 2021
related to ARIA in HTML PR w3c/html-aria#212, `role=radio` was meant to be kept as an allowance for an `img` with an accessible name, but it didn't make it into the spec. w3c/html-aria#381 will add this allowance
scottaohara
added a commit
to scottaohara/WAI-ARIA-Usage
that referenced
this pull request
Dec 3, 2021
related to ARIA in HTML PR w3c/html-aria#212, `role=radio` was meant to be kept as an allowance for an `img` with an accessible name, but it didn't make it into the spec. w3c/html-aria#381 will add this allowance. This PR adds this allowance.
This was referenced Dec 3, 2021
sideshowbarker
pushed a commit
to validator/validator
that referenced
this pull request
Jan 21, 2022
related to ARIA in HTML PR w3c/html-aria#212, `role=radio` was meant to be kept as an allowance for an `img` with an accessible name, but it didn't make it into the spec. w3c/html-aria#381 will add this allowance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #166
this PR does the following:
limits the allowed roles on an
imgwithalt=some_text.disallows any role on an
imgwithout analtattribute (some screen readers will ignore animgwithout analt. some will announce the file name. rather we not allow arole=buttonwithout an accessible name, or with a name "photo-1.jpg").If an
imgis provided an authored defined accessible name via other means (aria-label,aria-labelledby,title) then same allowances asimg alt="some text".I'd be more than open to whittling the allowed roles down further, or hearing reasons to add some back in.
Preview | Diff